[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage,
whose observer was acknowledging to the wrong source.

BUG=697086
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2789143002
Cr-Commit-Position: refs/heads/master@{#461670}
Committed: https://chromium.googlesource.com/chromium/src/+/bc1653a4f1a74aba2540fd0f59298d1c2c6601c5

[Eric Seckler, 2017-04-03 11:54:11]

Description was changed from

==========
[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage.

BUG=697086
==========

to

==========
[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage.

BUG=697086
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Eric Seckler, 2017-04-03 11:56:27]

Patchset #1 (id:1) has been deleted

[Eric Seckler, 2017-04-03 11:57:03]

Description was changed from

==========
[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage.

BUG=697086
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage,
whose observer was acknowledging to the wrong source.

BUG=697086
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Eric Seckler, 2017-04-03 11:58:31]

eseckler@chromium.org changed reviewers:
+ brianderson@chromium.org

[Eric Seckler, 2017-04-03 11:58:32]

Brian, PTAL :)

[brianderson, 2017-04-04 00:01:57]

lgtm

https://codereview.chromium.org/2789143002/diff/40001/cc/surfaces/compositor_...
File cc/surfaces/compositor_frame_sink_support.cc (right):

https://codereview.chromium.org/2789143002/diff/40001/cc/surfaces/compositor_...
cc/surfaces/compositor_frame_sink_support.cc:101: BeginFrameAck ack =
frame.metadata.begin_frame_ack;
Could this be a const ref?

[Eric Seckler, 2017-04-04 07:34:05]

Thanks, Brian!

https://codereview.chromium.org/2789143002/diff/40001/cc/surfaces/compositor_...
File cc/surfaces/compositor_frame_sink_support.cc (right):

https://codereview.chromium.org/2789143002/diff/40001/cc/surfaces/compositor_...
cc/surfaces/compositor_frame_sink_support.cc:101: BeginFrameAck ack =
frame.metadata.begin_frame_ack;
On 2017/04/04 00:01:57, brianderson wrote:
> Could this be a const ref?

I don't think that'd be safe, since we're moving |frame| below, thus
relinquishing ownership. (The use of frame.metadata.begin_frame_ack after the
move was broken below; we copy here to fix that.)

[Eric Seckler, 2017-04-04 07:34:19]

The CQ bit was checked by eseckler@chromium.org

[commit-bot: I haz the power, 2017-04-04 07:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 09:52:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491291259930870,
"parent_rev": "bf66b1c4361927a712b75d2239015a599aeb7d4a", "commit_rev":
"bc1653a4f1a74aba2540fd0f59298d1c2c6601c5"}

[commit-bot: I haz the power, 2017-04-04 09:53:32]

Description was changed from

==========
[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage,
whose observer was acknowledging to the wrong source.

BUG=697086
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
[cc] Test that CFSSupport forwards BeginFrameAcks in CompositorFrames.

Also fixes
DirectCompositorFrameSinkTest.AcknowledgesBeginFramesWithoutDamage,
whose observer was acknowledging to the wrong source.

BUG=697086
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2789143002
Cr-Commit-Position: refs/heads/master@{#461670}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc1653a4f1a74aba2540fd0f5929...
==========

[commit-bot: I haz the power, 2017-04-04 09:53:33]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bc1653a4f1a74aba2540fd0f5929...