[turbofan] Relax constraints on apply with arguments optimization.

[turbofan] Relax constraints on apply with arguments optimization.

For sloppy arguments in functions with declared formal parameters, the
apply with arguments optimization in TurboFan wouldn't kick in
currently, because so far there was no guard to see if using the
arguments from the stack or the frame state is safe. One easy to check
guard here is to just check that there's no observable side-effect
between the actual arguments creation and the call to apply.

BUG=v8:5267, v8:6200
R=danno@chromium.org

Review-Url: https://codereview.chromium.org/2789113004
Cr-Commit-Position: refs/heads/master@{#44363}
Committed: https://chromium.googlesource.com/v8/v8/+/e8c109e2788b59e2b96243131fc17554ca53de32

[Benedikt Meurer, 2017-04-04 07:36:19]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 07:36:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-04-04 07:55:11]

lgtm with comment

https://codereview.chromium.org/2789113004/diff/1/src/compiler/js-call-reduce...
File src/compiler/js-call-reducer.cc (right):

https://codereview.chromium.org/2789113004/diff/1/src/compiler/js-call-reduce...
src/compiler/js-call-reducer.cc:147: Node* effect =
NodeProperties::GetEffectInput(node);
Does it make sense to turn this into a predicate? e.g. 

if (NodeProperties::HasWriteEffectBetween(node, arg_array)) return NoChange();

[Benedikt Meurer, 2017-04-04 08:02:14]

https://codereview.chromium.org/2789113004/diff/1/src/compiler/js-call-reduce...
File src/compiler/js-call-reducer.cc (right):

https://codereview.chromium.org/2789113004/diff/1/src/compiler/js-call-reduce...
src/compiler/js-call-reducer.cc:147: Node* effect =
NodeProperties::GetEffectInput(node);
Given that we might want to relax the constraints here, which would mean looking
closer at the specific operation in effect, this predicate wouldn't be used here
long-/middle-term.

[Benedikt Meurer, 2017-04-04 08:03:07]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-04 08:03:11]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-04-04 08:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 08:04:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491292991309340, "parent_rev":
"68c14892cbf1ec2e6fb52752c79a3313e0b33786", "commit_rev":
"e8c109e2788b59e2b96243131fc17554ca53de32"}

[commit-bot: I haz the power, 2017-04-04 08:04:43]

Description was changed from

==========
[turbofan] Relax constraints on apply with arguments optimization.

For sloppy arguments in functions with declared formal parameters, the
apply with arguments optimization in TurboFan wouldn't kick in
currently, because so far there was no guard to see if using the
arguments from the stack or the frame state is safe. One easy to check
guard here is to just check that there's no observable side-effect
between the actual arguments creation and the call to apply.

BUG=v8:5267,v8:6200
R=danno@chromium.org
==========

to

==========
[turbofan] Relax constraints on apply with arguments optimization.

For sloppy arguments in functions with declared formal parameters, the
apply with arguments optimization in TurboFan wouldn't kick in
currently, because so far there was no guard to see if using the
arguments from the stack or the frame state is safe. One easy to check
guard here is to just check that there's no observable side-effect
between the actual arguments creation and the call to apply.

BUG=v8:5267,v8:6200
R=danno@chromium.org

Review-Url: https://codereview.chromium.org/2789113004
Cr-Commit-Position: refs/heads/master@{#44363}
Committed:
https://chromium.googlesource.com/v8/v8/+/e8c109e2788b59e2b96243131fc17554ca5...
==========

[commit-bot: I haz the power, 2017-04-04 08:04:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e8c109e2788b59e2b96243131fc17554ca5...