Mark QUIC broken when the network blackholes after the handshake

net/http/http_network_transaction.cc

Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index e0105c60396fe3f891916b12114cff7c14da899b..7f98949f7eccebd6a78dc4a82ca5a72330b76cfc 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -1533,6 +1533,15 @@ int HttpNetworkTransaction::HandleIOError(int error) {
         error = OK;
       }
       break;
+    case ERR_QUIC_BROKEN_ERROR:
+      if (GetResponseHeaders() == nullptr) {
+        net_log_.AddEventWithNetErrorCode(
+            NetLogEventType::HTTP_TRANSACTION_RESTART_AFTER_ERROR, error);
+        ResetConnectionAndRequestForResend();
+        error = OK;
+        break;
+      }
+      error = ERR_QUIC_PROTOCOL_ERROR;

[mmenke, 2017/04/03 18:47:47]

I don't think this is meant to fall through.  Should have a test for this.

[mmenke, 2017/04/03 18:48:34]

Also, a comment on what one error is being replaced by another might be
useful...And the reason we care about having headers, for that matter.

[Ryan Hamilton, 2017/04/05 19:26:20]

Agreed. Though this has been reworked and is now moot.

[Ryan Hamilton, 2017/04/05 19:26:20]

*facepalm* Yes indeed :( Thanks!
Definitely! Interestingly, after attempting to write a test for this, it turns
out that this code is unreachable because this method (HandleIOError) is not
called after headers have been received. This is a bit confusing to me because
ShouldResendRequest() also checks that headers have not been received, so it
seems a bit redundant. Curious.

Anyway, this led me to rework the logic.

     case ERR_SPDY_PING_FAILED:
     case ERR_SPDY_SERVER_REFUSED_STREAM:
     case ERR_QUIC_HANDSHAKE_FAILED: