Mark QUIC broken when the network blackholes after the handshake

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 1515 matching lines @@
     // ERR_EMPTY_RESPONSE. This may still be close/reuse race if the socket was
     // preconnected but failed to be used before the server timed it out.
     case ERR_EMPTY_RESPONSE:
       if (ShouldResendRequest()) {
         net_log_.AddEventWithNetErrorCode(
             NetLogEventType::HTTP_TRANSACTION_RESTART_AFTER_ERROR, error);
         ResetConnectionAndRequestForResend();
         error = OK;
       }
       break;
+    case ERR_QUIC_BROKEN_ERROR:
+      if (GetResponseHeaders() == nullptr) {
+        net_log_.AddEventWithNetErrorCode(
+            NetLogEventType::HTTP_TRANSACTION_RESTART_AFTER_ERROR, error);
+        ResetConnectionAndRequestForResend();
+        error = OK;
+        break;
+      }
+      error = ERR_QUIC_PROTOCOL_ERROR;

[mmenke, 2017/04/03 18:47:47]

I don't think this is meant to fall through.  Should have a test for this.

[mmenke, 2017/04/03 18:48:34]

Also, a comment on what one error is being replaced by another might be
useful...And the reason we care about having headers, for that matter.

[Ryan Hamilton, 2017/04/05 19:26:20]

Agreed. Though this has been reworked and is now moot.

[Ryan Hamilton, 2017/04/05 19:26:20]

*facepalm* Yes indeed :( Thanks!
Definitely! Interestingly, after attempting to write a test for this, it turns
out that this code is unreachable because this method (HandleIOError) is not
called after headers have been received. This is a bit confusing to me because
ShouldResendRequest() also checks that headers have not been received, so it
seems a bit redundant. Curious.

Anyway, this led me to rework the logic.

     case ERR_SPDY_PING_FAILED:
     case ERR_SPDY_SERVER_REFUSED_STREAM:
     case ERR_QUIC_HANDSHAKE_FAILED:
       net_log_.AddEventWithNetErrorCode(
           NetLogEventType::HTTP_TRANSACTION_RESTART_AFTER_ERROR, error);
       ResetConnectionAndRequestForResend();
       error = OK;
       break;
     case ERR_MISDIRECTED_REQUEST:
       // If this is the second try, just give up.
@@ skipping 166 matching lines @@
   DCHECK(stream_request_);
 
   // Since the transaction can restart with auth credentials, it may create a
   // stream more than once. Accumulate all of the connection attempts across
   // those streams by appending them to the vector:
   for (const auto& attempt : stream_request_->connection_attempts())
     connection_attempts_.push_back(attempt);
 }
 
 }  // namespace net