[Payments] Desktop: implement shipping address/option change

[Payments] Desktop: implement shipping address/option change

Now when an address/shipping option is selected, the information
goes to the merchant and when updateWith eventually gets called,
the information is updated in the UI.

Moved the selection of the shipping option to the spec, as we merely
forward the selection event to the merchant and recompute from the
PaymentDetails when updateWith is called.

Modified DialogEventObserver so that it can observe a sequence of
events.

BUG=707240
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2789093002
Cr-Commit-Position: refs/heads/master@{#461537}
Committed: https://chromium.googlesource.com/chromium/src/+/151bd31ea040cb745cdc07e59d4b097186ec3ab3

[Mathieu, 2017-04-03 03:27:19]

Description was changed from

==========
[Payments] Desktop: implement shipping address/option change

BUG=707240
TEST=components_unittests, browser_tests
==========

to

==========
[Payments] Desktop: implement shipping address/option change

Now when an address/shipping option is selected, the information
goes to the merchant and when updateWith eventually gets called,
the information is updated in the UI.

Moved the selection of the shipping option to the spec, as we merely
forward the selection event to the merchant and recompute from the
PaymentDetails when updateWith is called.

Modified DialogEventObserver so that it can observe a sequence of
events.

BUG=707240
TEST=components_unittests, browser_tests
==========

[Mathieu, 2017-04-03 03:27:19]

mathp@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Mathieu, 2017-04-03 03:27:28]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 03:27:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 03:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 03:40:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-04-03 11:54:06]

Anthony, PTAL

[Mathieu, 2017-04-03 11:54:11]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 11:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 12:28:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 12:28:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mathieu, 2017-04-03 15:00:50]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 15:01:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-04-03 15:09:58]

lgtm

https://codereview.chromium.org/2789093002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2789093002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:251: //
TODO(crbug.com/xxxxxx): Put a better placeholder row, instead of no row.
nit: you might want an actual bug # here.

[Mathieu, 2017-04-03 16:27:27]

Thanks!

https://codereview.chromium.org/2789093002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2789093002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:251: //
TODO(crbug.com/xxxxxx): Put a better placeholder row, instead of no row.
On 2017/04/03 15:09:58, anthonyvd wrote:
> nit: you might want an actual bug # here.

Done.

[Mathieu, 2017-04-03 16:27:55]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-03 16:27:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2789093002/#ps60001
(title: "bug number in TODO")

[commit-bot: I haz the power, 2017-04-03 16:28:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-03 16:47:19]

The CQ bit was unchecked by mathp@chromium.org

[Mathieu, 2017-04-03 17:43:15]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-03 17:43:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2789093002/#ps80001
(title: "make string copy")

[commit-bot: I haz the power, 2017-04-03 17:44:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:55:55]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-04-03 18:51:45]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-03 18:51:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2789093002/#ps100001
(title: "compile fix")

[commit-bot: I haz the power, 2017-04-03 18:52:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:07:32]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491245505354250,
"parent_rev": "b9330b894cc798fff68fd9acc42572c32af4d159", "commit_rev":
"151bd31ea040cb745cdc07e59d4b097186ec3ab3"}

[commit-bot: I haz the power, 2017-04-03 21:08:23]

Description was changed from

==========
[Payments] Desktop: implement shipping address/option change

Now when an address/shipping option is selected, the information
goes to the merchant and when updateWith eventually gets called,
the information is updated in the UI.

Moved the selection of the shipping option to the spec, as we merely
forward the selection event to the merchant and recompute from the
PaymentDetails when updateWith is called.

Modified DialogEventObserver so that it can observe a sequence of
events.

BUG=707240
TEST=components_unittests, browser_tests
==========

to

==========
[Payments] Desktop: implement shipping address/option change

Now when an address/shipping option is selected, the information
goes to the merchant and when updateWith eventually gets called,
the information is updated in the UI.

Moved the selection of the shipping option to the spec, as we merely
forward the selection event to the merchant and recompute from the
PaymentDetails when updateWith is called.

Modified DialogEventObserver so that it can observe a sequence of
events.

BUG=707240
TEST=components_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2789093002
Cr-Commit-Position: refs/heads/master@{#461537}
Committed:
https://chromium.googlesource.com/chromium/src/+/151bd31ea040cb745cdc07e59d4b...
==========

[commit-bot: I haz the power, 2017-04-03 21:08:24]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/151bd31ea040cb745cdc07e59d4b...