Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2789053002: [sensors][permission] Add/Register sensor permission types in content_settings.

Created:
3 years, 8 months ago by riju_
Modified:
3 years, 8 months ago
CC:
chromium-reviews, markusheintz_, mlamouri+watch-permissions_chromium.org, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors][permission] Add/Register in content_settings. We register the content settings for different sensors. The policy as suggesed by chrome privacy team is -> AMBIENT_LIGHT_SENSOR: opt-out UI. granted by default. MAGNETOMETER: opt-out UI. granted by default. ORIENTATION_SENSOR: opt-out UI. granted by default. ACCELEROMETER: auto-grant. no UI. GYROSCOPE: auto grant. no UI. BUG=606766

Patch Set 1 #

Patch Set 2 : Remove TODO #

Patch Set 3 : Use WebsiteSettingsInfo::UNSYNCABLE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M chrome/browser/permissions/permission_manager.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M components/content_settings/core/browser/content_settings_registry.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M components/content_settings/core/common/content_settings_types.h View 1 chunk +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
riju_
PTAL. This is part 2 of adding permission guard for sensors based on Generic Sensor ...
3 years, 8 months ago (2017-04-04 15:37:53 UTC) #2
mlamouri (slow - plz ping)
lgtm but please wait for raymes@
3 years, 8 months ago (2017-04-05 13:18:03 UTC) #3
raymes
Hey riju, The code here is starting to be dependent on what UI surfaces we ...
3 years, 8 months ago (2017-04-06 05:39:21 UTC) #4
raymes
You may want to include a section in the design doc on UI and CC ...
3 years, 8 months ago (2017-04-06 05:48:29 UTC) #5
shalamov
3 years, 8 months ago (2017-04-13 12:33:22 UTC) #6
On 2017/04/06 05:48:29, raymes wrote:
> You may want to include a section in the design doc on UI and CC folks like
> owencm, benwells, dominickn, emilyschechter.
> 
> Thanks!

Added chapter about Chrome UI with mocks
(https://docs.google.com/document/d/1Ml65ZdW5AgIsZTszk4mD_ohr40pcrdVFOIf0ZtWxD...)

CC'd owencm, benwells, dominickn, emilyschechter.

Powered by Google App Engine
This is Rietveld 408576698