Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2789003002: Upstream service worker ext. event tests to WPT (Closed)

Created:
3 years, 8 months ago by mike3
Modified:
3 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker ext. event tests to WPT The Web Platform Tests project includes equivalent versions of these tests. - `extendable-event-async-waituntil.html` - the version in WPT has been extended with additional assertions, rendering the Chromium version obsolete. - `extendable-event-waituntil.html` - the version in WPT has been extended to support (but not require) more rigorous compliance with the specification. Update that test to be more precise and document the expected failure in the Chromium infrastructure. BUG=688116, 709591 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2789003002 Cr-Commit-Position: refs/heads/master@{#463003} Committed: https://chromium.googlesource.com/chromium/src/+/406fa418432ec6bcb3b40f2fa95b30da5175e581

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
mike3
@falken The WPT version of `extendable-event-waituntil.https.html` includes a very subtle change: @@ -68,11 +68,13 @@ ...
3 years, 8 months ago (2017-03-31 21:36:14 UTC) #1
falken
Sorry, I know I'm late on this review. Trying to get to it soon.
3 years, 8 months ago (2017-04-06 06:39:17 UTC) #2
mike3
On 2017/04/06 06:39:17, falken (ooo-ish until Apr 5) wrote: > Sorry, I know I'm late ...
3 years, 8 months ago (2017-04-06 23:38:02 UTC) #3
falken
This change lgtm. I agree the spec demands waiting for all promises, nice catch. I ...
3 years, 8 months ago (2017-04-07 05:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789003002/1
3 years, 8 months ago (2017-04-07 19:50:11 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 21:12:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/406fa418432ec6bcb3b40f2fa95b...

Powered by Google App Engine
This is Rietveld 408576698