Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList.

This does mean we do one extra branch per element in the cases of
selectors like '.a' for each element that does actually have this class
name, but that seems fine given the cost of allocating wrappers and
everything else that's going to happen after returning the matches.

After removing the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900
Review-Url: https://codereview.chromium.org/2788953003
Cr-Commit-Position: refs/heads/master@{#461316}
Committed: https://chromium.googlesource.com/chromium/src/+/00b1fe65b09e25713e2ebb7c0e940be33cdfb7c7

[esprehn, 2017-03-31 23:41:30]

Description was changed from

==========
Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList. This does mean we do one
extra branch per element in the cases of selectors like '.a' for each
element that does actually have this class name, but that seems fine
given the cost of allocating wrappers and everything else that's going
to happen after returning the matches.

After removing the the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900
==========

to

==========
Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList.

This does mean we do one extra branch per element in the cases of
selectors like '.a' for each element that does actually have this class
name, but that seems fine given the cost of allocating wrappers and
everything else that's going to happen after returning the matches.

After removing the the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900
==========

[esprehn, 2017-03-31 23:41:53]

Description was changed from

==========
Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList.

This does mean we do one extra branch per element in the cases of
selectors like '.a' for each element that does actually have this class
name, but that seems fine given the cost of allocating wrappers and
everything else that's going to happen after returning the matches.

After removing the the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900
==========

to

==========
Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList.

This does mean we do one extra branch per element in the cases of
selectors like '.a' for each element that does actually have this class
name, but that seems fine given the cost of allocating wrappers and
everything else that's going to happen after returning the matches.

After removing the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900
==========

[esprehn, 2017-03-31 23:44:50]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 23:45:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-04-01 00:06:06]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-04-01 00:06:06]

lgtm

[commit-bot: I haz the power, 2017-04-01 00:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 00:42:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[esprehn, 2017-04-01 03:51:03]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 03:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-04-01 04:45:18]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2017-04-01 04:45:21]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2017-04-01 04:45:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org
Link to the patchset: https://codereview.chromium.org/2788953003/#ps20001
(title: "Woops missed a return.")

[commit-bot: I haz the power, 2017-04-01 04:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 05:36:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491021921023740,
"parent_rev": "5e8b428fff011c6bb85fa02a5bdc754b2360a370", "commit_rev":
"00b1fe65b09e25713e2ebb7c0e940be33cdfb7c7"}

[commit-bot: I haz the power, 2017-04-01 05:36:46]

Description was changed from

==========
Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList.

This does mean we do one extra branch per element in the cases of
selectors like '.a' for each element that does actually have this class
name, but that seems fine given the cost of allocating wrappers and
everything else that's going to happen after returning the matches.

After removing the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900
==========

to

==========
Remove ClassElementList and reuse collectElementsByClassName in SelectorQuery.

We can add a check to collectElementsByClassName to match a full
selector once we find an element with a matching class name and remove
the AllElements mode of the ClassElementList.

This does mean we do one extra branch per element in the cases of
selectors like '.a' for each element that does actually have this class
name, but that seems fine given the cost of allocating wrappers and
everything else that's going to happen after returning the matches.

After removing the AllElements mode we can inline the loop for
ClassElementList into the caller and remove this iterator abstraction
entirely.

BUG=703900

Review-Url: https://codereview.chromium.org/2788953003
Cr-Commit-Position: refs/heads/master@{#461316}
Committed:
https://chromium.googlesource.com/chromium/src/+/00b1fe65b09e25713e2ebb7c0e94...
==========

[commit-bot: I haz the power, 2017-04-01 05:36:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00b1fe65b09e25713e2ebb7c0e94...