Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2788893003:
Switch all LayoutTests owned by layout-dev team to be 'ImageFirst' tests (Closed)
|
Created:
3 years, 8 months ago by Gleb Lanbin Modified:
3 years, 8 months ago Reviewers:
eae CC:
chromium-reviews, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitch all LayoutTests owned by layout-dev team to be 'ImageFirst' tests
Add all LayoutTests folders owned by layout-dev to ImageFirstTests file.
That will tell run-webkit-tests to prioritize image over txt baselines
for all test in specified folders.
BUG=703899
Review-Url: https://codereview.chromium.org/2788893003
Cr-Commit-Position: refs/heads/master@{#461874}
Committed: https://chromium.googlesource.com/chromium/src/+/13a18597e1078a96d032601556e299fa7c35d691
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
glebl@chromium.org changed reviewers: + eae@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Excellent. Do you plan to delete the -expected.txt files in a follow up change? LGTM
On 2017/04/03 22:39:00, eae wrote: > Excellent. Do you plan to delete the -expected.txt files in a follow up change? > > LGTM yes, I will send a follow-up patch to remove -expected.txt files from related folders.
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491344272466410, "parent_rev":
"b8a3aab2bfabcf85262d12768bae81f10f913218", "commit_rev":
"13a18597e1078a96d032601556e299fa7c35d691"}
Message was sent while issue was closed.
Description was changed from ========== Switch all LayoutTests owned by layout-dev team to be 'ImageFirst' tests Add all LayoutTests folders owned by layout-dev to ImageFirstTests file. That will tell run-webkit-tests to prioritize image over txt baselines for all test in specified folders. BUG=703899 ========== to ========== Switch all LayoutTests owned by layout-dev team to be 'ImageFirst' tests Add all LayoutTests folders owned by layout-dev to ImageFirstTests file. That will tell run-webkit-tests to prioritize image over txt baselines for all test in specified folders. BUG=703899 Review-Url: https://codereview.chromium.org/2788893003 Cr-Commit-Position: refs/heads/master@{#461874} Committed: https://chromium.googlesource.com/chromium/src/+/13a18597e1078a96d032601556e2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/13a18597e1078a96d032601556e2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
