Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2788883003: Move storage test next to the file that it tests (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
dmurph
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move storage test next to the file that it tests. BUG=653751 Review-Url: https://codereview.chromium.org/2788883003 Cr-Commit-Position: refs/heads/master@{#461955} Committed: https://chromium.googlesource.com/chromium/src/+/0d3b75cb632ce1f29f9888afe995e35caf1a7fe6

Patch Set 1 : Clean up unnecessary includes from content/ #

Patch Set 2 : The actual move. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -902 lines) Patch
M content/browser/blob_storage/blob_storage_context_unittest.cc View 1 1 chunk +0 lines, -898 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + storage/browser/blob/blob_storage_context_unittest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
pwnall
PTAL?
3 years, 8 months ago (2017-03-31 19:51:14 UTC) #6
dmurph
lgtm
3 years, 8 months ago (2017-04-04 21:58:07 UTC) #10
pwnall
On 2017/04/04 21:58:07, dmurph wrote: > lgtm Thank you very much for the review!
3 years, 8 months ago (2017-04-04 22:11:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788883003/20001
3 years, 8 months ago (2017-04-04 22:11:56 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/264564)
3 years, 8 months ago (2017-04-05 01:31:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788883003/20001
3 years, 8 months ago (2017-04-05 02:04:57 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 02:52:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d3b75cb632ce1f29f9888afe995...

Powered by Google App Engine
This is Rietveld 408576698