[regexp] Allow named captures and back-references in non-unicode patterns

[regexp] Allow named captures and back-references in non-unicode patterns

Previously, named captures (and related functionality) were restricted to
unicode-mode regexps.

This CL extends that support to non-unicode patterns. Named groups are
supported regardless of the mode, and named back-references are supported if
the regexp is in unicode mode or if it contains a named capture (otherwise '\k'
is treated as an identity escape).

BUG=v8:5437, v8:6192
Review-Url: https://codereview.chromium.org/2788873002
Cr-Commit-Position: refs/heads/master@{#44324}
Committed: https://chromium.googlesource.com/v8/v8/+/a3be9e78c1bdb9332853cf37004697b737f1665f

[jgruber, 2017-03-31 11:41:18]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 11:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-31 11:53:00]

jgruber@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[jgruber, 2017-03-31 11:53:01]

Hi folks,

this CL implements non-unicode named capture support without doing a full second
parse pass by using the capture-counting mini-parser (ScanForCaptures).

PTAL.

https://codereview.chromium.org/2788873002/diff/1/test/mjsunit/harmony/regexp...
File test/mjsunit/harmony/regexp-named-captures.js (right):

https://codereview.chromium.org/2788873002/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-named-captures.js:150: assertThrows("/(?<$𐒤>a)/",
SyntaxError);
This one may be an issue. The regexp parser doesn't Advance() properly here
without /u, causing a failure in the IdentifierContinue::Is check for the
leading surrogate.

It's probably best to file a bug for this and fix it later on.

[commit-bot: I haz the power, 2017-03-31 12:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 12:07:40]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-04-03 06:58:17]

Description was changed from

==========
[regexp] Allow named captures and back-references in non-unicode patterns

Previously, named captures (and related functionality) were restricted to
unicode-mode regexps.

This CL extends that support to non-unicode patterns. Named groups are
supported regardless of the mode, and named back-references are supported if
the regexp is in unicode mode or if it contains a named capture (otherwise '\k'
is treated as an identity escape).

BUG=v8:5437
==========

to

==========
[regexp] Allow named captures and back-references in non-unicode patterns

Previously, named captures (and related functionality) were restricted to
unicode-mode regexps.

This CL extends that support to non-unicode patterns. Named groups are
supported regardless of the mode, and named back-references are supported if
the regexp is in unicode mode or if it contains a named capture (otherwise '\k'
is treated as an identity escape).

BUG=v8:5437,v8:6192
==========

[jgruber, 2017-04-03 06:58:42]

On 2017/03/31 11:53:01, jgruber wrote:
> It's probably best to file a bug for this and fix it later on.

And this is the bug: crbug.com/v8/6192.

[Yang, 2017-04-03 07:26:05]

On 2017/04/03 06:58:42, jgruber wrote:
> On 2017/03/31 11:53:01, jgruber wrote:
> > It's probably best to file a bug for this and fix it later on.
> 
> And this is the bug: crbug.com/v8/6192.

lgtm.

[jgruber, 2017-04-03 07:38:06]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-03 07:38:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 08:03:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491205086798730, "parent_rev":
"ee81214a4e2faf53ab0a34fd9cc8333d25d4592c", "commit_rev":
"a3be9e78c1bdb9332853cf37004697b737f1665f"}

[commit-bot: I haz the power, 2017-04-03 08:03:14]

Description was changed from

==========
[regexp] Allow named captures and back-references in non-unicode patterns

Previously, named captures (and related functionality) were restricted to
unicode-mode regexps.

This CL extends that support to non-unicode patterns. Named groups are
supported regardless of the mode, and named back-references are supported if
the regexp is in unicode mode or if it contains a named capture (otherwise '\k'
is treated as an identity escape).

BUG=v8:5437,v8:6192
==========

to

==========
[regexp] Allow named captures and back-references in non-unicode patterns

Previously, named captures (and related functionality) were restricted to
unicode-mode regexps.

This CL extends that support to non-unicode patterns. Named groups are
supported regardless of the mode, and named back-references are supported if
the regexp is in unicode mode or if it contains a named capture (otherwise '\k'
is treated as an identity escape).

BUG=v8:5437,v8:6192

Review-Url: https://codereview.chromium.org/2788873002
Cr-Commit-Position: refs/heads/master@{#44324}
Committed:
https://chromium.googlesource.com/v8/v8/+/a3be9e78c1bdb9332853cf37004697b737f...
==========

[commit-bot: I haz the power, 2017-04-03 08:03:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a3be9e78c1bdb9332853cf37004697b737f...