Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2788863005: crosh_builtin: update name to be more friendly (Closed)

Created:
3 years, 8 months ago by vapier
Modified:
3 years, 8 months ago
Reviewers:
achuithb, stevenjb
CC:
alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

crosh_builtin: update name to be more friendly We don't translate this, but nothing in crosh is translated either. BUG=chromium:677623 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2788863005 Cr-Commit-Position: refs/heads/master@{#461329} Committed: https://chromium.googlesource.com/chromium/src/+/3861aa1017702ce97842ed438c5da30dc2f591c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/crosh_builtin/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
vapier
3 years, 8 months ago (2017-04-01 04:31:57 UTC) #3
achuithb
lgtm
3 years, 8 months ago (2017-04-01 18:04:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788863005/1
3 years, 8 months ago (2017-04-01 19:41:02 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 19:58:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3861aa1017702ce97842ed438c5d...

Powered by Google App Engine
This is Rietveld 408576698