Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2788793004: Convert StereoPanner tests to use new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert StereoPanner tests to use new Audit Manually converted tests to use new Audit. BUG=704967 TEST= StereoPanner/stereopannernode-no-glitch.html StereoPanner/stereopannernode-panning.html Review-Url: https://codereview.chromium.org/2788793004 Cr-Commit-Position: refs/heads/master@{#469020} Committed: https://chromium.googlesource.com/chromium/src/+/d8478a85a577aa1ac3d1bfb1a6f1d81e3de9e385

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove commented-out code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -67 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html View 6 chunks +22 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-panning.html View 2 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js View 1 2 chunks +16 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-01 15:20:36 UTC) #2
hongchan
https://codereview.chromium.org/2788793004/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js (right): https://codereview.chromium.org/2788793004/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js#newcode200 third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js:200: */ Please take one more look at the line ...
3 years, 7 months ago (2017-05-02 16:40:25 UTC) #3
Raymond Toy
https://codereview.chromium.org/2788793004/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js File third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js (right): https://codereview.chromium.org/2788793004/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js#newcode200 third_party/WebKit/LayoutTests/webaudio/resources/stereopanner-testing.js:200: */ On 2017/05/02 16:40:25, hongchan wrote: > Please take ...
3 years, 7 months ago (2017-05-02 19:17:16 UTC) #4
hongchan
lgtm
3 years, 7 months ago (2017-05-03 15:44:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788793004/20001
3 years, 7 months ago (2017-05-03 15:59:34 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:30:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d8478a85a577aa1ac3d1bfb1a6f1...

Powered by Google App Engine
This is Rietveld 408576698