Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: gpu/command_buffer/service/context_state.cc

Issue 2788793003: gpu: Support other buffer targets for ScopedBufferBinder (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/context_state.cc
diff --git a/gpu/command_buffer/service/context_state.cc b/gpu/command_buffer/service/context_state.cc
index 7259d753b628349c4598f445b835408592d50610..28b48147ef79d6665fdb39fa45cc3fa1c3a2d3b6 100644
--- a/gpu/command_buffer/service/context_state.cc
+++ b/gpu/command_buffer/service/context_state.cc
@@ -77,16 +77,6 @@ bool TargetIsSupported(const FeatureInfo* feature_info, GLuint target) {
}
}
-bool BufferTargetIsSupported(GLuint target) {
- switch (target) {
- case GL_ARRAY_BUFFER:
- return true;
- default:
- NOTREACHED();
- return false;
- }
-}
-
GLuint GetBufferId(const Buffer* buffer) {
if (buffer)
return buffer->service_id();
@@ -317,8 +307,7 @@ void ContextState::DoLineWidth(GLfloat width) const {
}
void ContextState::RestoreBufferBinding(unsigned int target) const {
piman 2017/04/04 00:27:25 If we are not going to implement the other targets
Chandan 2017/04/04 12:14:00 I did not add other targets in BufferTargetIsSuppo
- if (BufferTargetIsSupported(target))
- glBindBuffer(target, GetBufferId(bound_array_buffer.get()));
+ glBindBuffer(target, GetBufferId(bound_array_buffer.get()));
}
void ContextState::RestoreBufferBindings() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698