gpu: Support other buffer targets for ScopedBufferBinder

gpu/command_buffer/service/context_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/context_state.h"
 
 #include <stddef.h>
 
 #include <cmath>
 
@@ skipping 59 matching lines @@
       return feature_info->feature_flags().arb_texture_rectangle;
     case GL_TEXTURE_EXTERNAL_OES:
       return feature_info->feature_flags().oes_egl_image_external ||
              feature_info->feature_flags().nv_egl_stream_consumer_external;
     default:
       NOTREACHED();
       return false;
   }
 }
 
-bool BufferTargetIsSupported(GLuint target) {
-  switch (target) {
-    case GL_ARRAY_BUFFER:
-      return true;
-    default:
-      NOTREACHED();
-      return false;
-  }
-}
-
 GLuint GetBufferId(const Buffer* buffer) {
   if (buffer)
     return buffer->service_id();
   return 0;
 }
 
 }  // anonymous namespace.
 
 TextureUnit::TextureUnit()
     : bind_target(GL_TEXTURE_2D) {
@@ skipping 209 matching lines @@
     glPixelStorei(GL_UNPACK_ROW_LENGTH, unpack_row_length);
     glPixelStorei(GL_UNPACK_IMAGE_HEIGHT, unpack_image_height);
   }
 }
 
 void ContextState::DoLineWidth(GLfloat width) const {
   glLineWidth(
       std::min(std::max(width, line_width_min_), line_width_max_));
 }
 
 void ContextState::RestoreBufferBinding(unsigned int target) const {

[piman, 2017/04/04 00:27:25]

If we are not going to implement the other targets, I would suggest renaming
this function to RestoreArrayBufferBinding, and removing the target parameter.

[Chandan, 2017/04/04 12:14:00]

I did not add other targets in BufferTargetIsSupported() to comply with
!state_restorer_ case in ScopedBufferBinder where only one target
GL_ARRAY_BUFFER is supported. 
We can definitely implement the other targets. I have uploaded patchset 2 with
support for other targets.

-  if (BufferTargetIsSupported(target))
-    glBindBuffer(target, GetBufferId(bound_array_buffer.get()));
+  glBindBuffer(target, GetBufferId(bound_array_buffer.get()));
 }
 
 void ContextState::RestoreBufferBindings() const {
   if (vertex_attrib_manager.get()) {
     Buffer* element_array_buffer =
         vertex_attrib_manager->element_array_buffer();
     glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, GetBufferId(element_array_buffer));
   }
   glBindBuffer(GL_ARRAY_BUFFER, GetBufferId(bound_array_buffer.get()));
   if (feature_info_->IsES3Capable()) {
@@ skipping 396 matching lines @@
   UpdateUnpackParameters();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/context_state_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu