[Cast,Android] Handle some PresentationAPI edge cases

[Cast,Android] Handle some PresentationAPI edge cases

Update MediaRouteObservers when the route is detached vs terminated.
Update MediaRouter about the route closed if there's no client record or
successful session.
All edge cases happen when the page is not using the Cast Web SDK.

BUG=706998
TEST=manually on https://googlechrome.github.io/samples/presentation-api/cast.html

Review-Url: https://codereview.chromium.org/2788783002
Cr-Commit-Position: refs/heads/master@{#463680}
Committed: https://chromium.googlesource.com/chromium/src/+/b265af93a6c5594f08c92a93a1c06cb0611c775d

[whywhat, 2017-03-30 22:12:17]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2017-03-30 22:12:18]

PTaL

[whywhat, 2017-03-30 22:12:24]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 22:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 23:15:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:15:40]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2017-03-31 11:23:59]

We really need tests for these: they are edge cases so they are likely to break
overlooked in the future. Can we add junit tests for the Java changes?

[whywhat, 2017-04-10 22:26:34]

Added tests to MediaRouterAndroid

[whywhat, 2017-04-10 22:34:28]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 22:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[whywhat, 2017-04-10 23:52:41]

Added CastMediaRouteProviderTest cases

[whywhat, 2017-04-10 23:54:17]

avayvod@chromium.org changed reviewers:
+ dtrainor@chromium.org

[whywhat, 2017-04-10 23:54:17]

+David for chrome_jni_registrar.cc

[whywhat, 2017-04-10 23:54:24]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 23:55:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 01:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:52:10]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mlamouri (slow - plz ping), 2017-04-11 13:18:12]

lgtm

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
File chrome/browser/media/android/router/media_router_android_bridge.cc (right):

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
chrome/browser/media/android/router/media_router_android_bridge.cc:5: #include
"chrome/browser/media/android/router/media_router_android_bridge.h"
I did not read this file and the header. Because it's boilerplate, I assume
there isn't anything interesting. Please let me know if you want me to have a
close look.

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
File chrome/browser/media/android/router/media_router_android_unittest.cc
(right):

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
chrome/browser/media/android/router/media_router_android_unittest.cc:58: void
TearDown() override {}
nit: could you just drop this?

[David Trainor- moved to gerrit, 2017-04-11 16:03:21]

chrome_jni_registrar lgtm!

[whywhat, 2017-04-11 16:35:00]

Fixed the unittests

[whywhat, 2017-04-11 16:36:12]

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
File chrome/browser/media/android/router/media_router_android_bridge.cc (right):

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
chrome/browser/media/android/router/media_router_android_bridge.cc:5: #include
"chrome/browser/media/android/router/media_router_android_bridge.h"
On 2017/04/11 at 13:18:12, mlamouri wrote:
> I did not read this file and the header. Because it's boilerplate, I assume
there isn't anything interesting. Please let me know if you want me to have a
close look.

Ack. That matches my expectations :)

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
File chrome/browser/media/android/router/media_router_android_unittest.cc
(right):

https://codereview.chromium.org/2788783002/diff/40001/chrome/browser/media/an...
chrome/browser/media/android/router/media_router_android_unittest.cc:58: void
TearDown() override {}
On 2017/04/11 at 13:18:12, mlamouri wrote:
> nit: could you just drop this?

Done.

[whywhat, 2017-04-11 16:36:16]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2017-04-11 16:36:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2788783002/#ps60001
(title: "Fixed the unittests")

[commit-bot: I haz the power, 2017-04-11 16:36:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 17:51:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491928576965570,
"parent_rev": "f6e00db21abb2680b4bb504e8d9345946ab7479e", "commit_rev":
"b265af93a6c5594f08c92a93a1c06cb0611c775d"}

[commit-bot: I haz the power, 2017-04-11 17:52:27]

Description was changed from

==========
[Cast,Android] Handle some PresentationAPI edge cases

Update MediaRouteObservers when the route is detached vs terminated.
Update MediaRouter about the route closed if there's no client record or
successful session.
All edge cases happen when the page is not using the Cast Web SDK.

BUG=706998
TEST=manually on
https://googlechrome.github.io/samples/presentation-api/cast.html
==========

to

==========
[Cast,Android] Handle some PresentationAPI edge cases

Update MediaRouteObservers when the route is detached vs terminated.
Update MediaRouter about the route closed if there's no client record or
successful session.
All edge cases happen when the page is not using the Cast Web SDK.

BUG=706998
TEST=manually on
https://googlechrome.github.io/samples/presentation-api/cast.html

Review-Url: https://codereview.chromium.org/2788783002
Cr-Commit-Position: refs/heads/master@{#463680}
Committed:
https://chromium.googlesource.com/chromium/src/+/b265af93a6c5594f08c92a93a1c0...
==========

[commit-bot: I haz the power, 2017-04-11 17:52:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b265af93a6c5594f08c92a93a1c0...