services/ui: make autorepeat work with accelerator.

services/ui: make autorepeat work with accelerator.

BUG=706571
Review-Url: https://codereview.chromium.org/2788753002
Cr-Commit-Position: refs/heads/master@{#461122}
Committed: https://chromium.googlesource.com/chromium/src/+/16dd65423c4063f423238456001c672464474a99

[Peng, 2017-03-30 20:50:09]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 20:51:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peng, 2017-03-30 20:53:08]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2017-03-30 20:53:08]

Hi Scott, PTAL. Thanks.

FYI, [1] is how key matching works in chrome.

[1]
https://cs.chromium.org/chromium/src/ui/base/accelerators/accelerator.cc?l=92...

[commit-bot: I haz the power, 2017-03-30 22:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:00:34]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-30 23:44:43]

LGTM

https://codereview.chromium.org/2788753002/diff/1/services/ui/ws/event_matche...
File services/ui/ws/event_matcher.cc (right):

https://codereview.chromium.org/2788753002/diff/1/services/ui/ws/event_matche...
services/ui/ws/event_matcher.cc:79: constexpr int kIgnoreFlags =
EF_IS_SYNTHESIZED | EF_IS_REPEAT;
Please add a comment here. Also, I would name this kSyntheticFlags or something
to better indicate these flags should never be matched against.

[Peng, 2017-03-31 14:09:22]

https://codereview.chromium.org/2788753002/diff/1/services/ui/ws/event_matche...
File services/ui/ws/event_matcher.cc (right):

https://codereview.chromium.org/2788753002/diff/1/services/ui/ws/event_matche...
services/ui/ws/event_matcher.cc:79: constexpr int kIgnoreFlags =
EF_IS_SYNTHESIZED | EF_IS_REPEAT;
On 2017/03/30 23:44:43, sky wrote:
> Please add a comment here. Also, I would name this kSyntheticFlags or
something
> to better indicate these flags should never be matched against.

Done.

[Peng, 2017-03-31 14:09:49]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2017-03-31 14:09:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2788753002/#ps20001
(title: "Address review issues.")

[commit-bot: I haz the power, 2017-03-31 14:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 15:03:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490969389414960,
"parent_rev": "8199d676ec703de9177ed4ce8a4e0712ba067be3", "commit_rev":
"16dd65423c4063f423238456001c672464474a99"}

[commit-bot: I haz the power, 2017-03-31 15:04:23]

Description was changed from

==========
services/ui: make autorepeat work with accelerator.

BUG=706571
==========

to

==========
services/ui: make autorepeat work with accelerator.

BUG=706571

Review-Url: https://codereview.chromium.org/2788753002
Cr-Commit-Position: refs/heads/master@{#461122}
Committed:
https://chromium.googlesource.com/chromium/src/+/16dd65423c4063f423238456001c...
==========

[commit-bot: I haz the power, 2017-03-31 15:04:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16dd65423c4063f423238456001c...