Add a way to get the test data folder from junit.

Add a way to get the test data folder from junit.

BUG=

Review-Url: https://codereview.chromium.org/2788733002
Cr-Commit-Position: refs/heads/master@{#463328}
Committed: https://chromium.googlesource.com/chromium/src/+/a92e7bd9d7d0c02f5350179b0fecbdef0e14b1ff

[ScottK, 2017-03-30 19:49:16]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:49:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-03-30 20:39:55]

scottkirkwood@chromium.org changed reviewers:
+ agrieve@chromium.org

[ScottK, 2017-03-30 20:39:56]

This is taken from the larger CL to be submitted separately.

[jbudorick, 2017-03-30 22:05:35]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[jbudorick, 2017-03-30 22:05:36]

+mikecase

[mikecase (-- gone --), 2017-03-30 22:23:36]

this lgtm

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
build/android/pylib/local/machine/local_machine_junit_test_run.py:33:
self._test_instance.suite)
nit: did you mean to change the indent here?

[commit-bot: I haz the power, 2017-03-30 22:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:46:13]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mikecase (-- gone --), 2017-03-31 01:30:01]

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
build/android/pylib/local/machine/local_machine_junit_test_run.py:45:
jar_args.extend(['-runner-filter', self._test_instance.runner_filter])
Should add, you could add -source-root arg here instead of using System
properties like you do below.

See...

https://cs.chromium.org/chromium/src/testing/android/junit/java/src/org/chrom...

The reason both are used currently is that Robolectric requires some configs be
set as System properties. Originally, all JUnit args were processed by the
JunitTestArgParser.

[ScottK, 2017-03-31 16:55:17]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:55:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-03-31 16:56:01]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:56:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ScottK, 2017-03-31 16:58:58]

Thanks for the review.

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
build/android/pylib/local/machine/local_machine_junit_test_run.py:33:
self._test_instance.suite)
On 2017/03/30 at 22:23:36, mikecase wrote:
> nit: did you mean to change the indent here?

Not sure what happened, my vim seems to be configured to auto fix indentation,
perhaps git was confused.

https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
build/android/pylib/local/machine/local_machine_junit_test_run.py:45:
jar_args.extend(['-runner-filter', self._test_instance.runner_filter])
On 2017/03/31 at 01:30:01, mikecase wrote:
> Should add, you could add -source-root arg here instead of using System
properties like you do below.
> 
> See...
> 
>
https://cs.chromium.org/chromium/src/testing/android/junit/java/src/org/chrom...
> 
> The reason both are used currently is that Robolectric requires some configs
be set as System properties. Originally, all JUnit args were processed by the
JunitTestArgParser.

I looked at adding to JUnitTestArgParser, but didn't see how to add it cleanly
so it can be used in junit tests.

The issue is that JunitTestMain creates a local JUnitTestArgParser internally,
but doesn't expose it.
I could have some static variables in JUnitTestArgParser that get set as a side
effect of parse, but that doesn't seem very intuitive.

Could we look at fixing this in another CL?

[commit-bot: I haz the power, 2017-03-31 17:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:23:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ScottK, 2017-03-31 18:19:02]

The CQ bit was checked by scottkirkwood@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 18:19:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 19:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 19:30:35]

Dry run: This issue passed the CQ dry run.

[ScottK, 2017-04-04 20:59:10]

On 2017/03/31 16:58:58, ScottK wrote:
> Thanks for the review.
> 
>
https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
> File build/android/pylib/local/machine/local_machine_junit_test_run.py
(right):
> 
>
https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
> build/android/pylib/local/machine/local_machine_junit_test_run.py:33:
> self._test_instance.suite)
> On 2017/03/30 at 22:23:36, mikecase wrote:
> > nit: did you mean to change the indent here?
> 
> Not sure what happened, my vim seems to be configured to auto fix indentation,
> perhaps git was confused.
> 
>
https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
> build/android/pylib/local/machine/local_machine_junit_test_run.py:45:
> jar_args.extend(['-runner-filter', self._test_instance.runner_filter])
> On 2017/03/31 at 01:30:01, mikecase wrote:
> > Should add, you could add -source-root arg here instead of using System
> properties like you do below.
> > 
> > See...
> > 
> >
>
https://cs.chromium.org/chromium/src/testing/android/junit/java/src/org/chrom...
> > 
> > The reason both are used currently is that Robolectric requires some configs
> be set as System properties. Originally, all JUnit args were processed by the
> JunitTestArgParser.
> 
> I looked at adding to JUnitTestArgParser, but didn't see how to add it cleanly
> so it can be used in junit tests.
> 
> The issue is that JunitTestMain creates a local JUnitTestArgParser internally,
> but doesn't expose it.
> I could have some static variables in JUnitTestArgParser that get set as a
side
> effect of parse, but that doesn't seem very intuitive.
> 
> Could we look at fixing this in another CL?

Ping?

[ScottK, 2017-04-04 20:59:51]

ping?

[jbudorick, 2017-04-10 16:54:53]

On 2017/03/30 22:23:36, mikecase wrote:
> this lgtm

lgtm stamp

> 
>
https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
> File build/android/pylib/local/machine/local_machine_junit_test_run.py
(right):
> 
>
https://codereview.chromium.org/2788733002/diff/1/build/android/pylib/local/m...
> build/android/pylib/local/machine/local_machine_junit_test_run.py:33:
> self._test_instance.suite)
> nit: did you mean to change the indent here?

[ScottK, 2017-04-10 17:06:12]

The CQ bit was checked by scottkirkwood@chromium.org

[ScottK, 2017-04-10 17:06:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2788733002/#ps40001
(title: "Fix python autoformat weirdness.")

[commit-bot: I haz the power, 2017-04-10 17:06:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 18:14:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491843972323050,
"parent_rev": "dfd67dbe4d4cd2a2ad36a5382cc72f01f8260fa0", "commit_rev":
"a92e7bd9d7d0c02f5350179b0fecbdef0e14b1ff"}

[commit-bot: I haz the power, 2017-04-10 18:15:32]

Description was changed from

==========
Add a way to get the test data folder from junit.

BUG=
==========

to

==========
Add a way to get the test data folder from junit.

BUG=

Review-Url: https://codereview.chromium.org/2788733002
Cr-Commit-Position: refs/heads/master@{#463328}
Committed:
https://chromium.googlesource.com/chromium/src/+/a92e7bd9d7d0c02f5350179b0fec...
==========

[commit-bot: I haz the power, 2017-04-10 18:15:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a92e7bd9d7d0c02f5350179b0fec...