Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2788723003: Disable MemoryDumpManagerTest.RegistrationConsistency and DisableTracingWhileDumping (Closed)

Created:
3 years, 8 months ago by ortuno
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, hjd
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MemoryDumpManagerTest.RegistrationConsistency and DisableTracingWhileDumping Disabling flaky test. TBR=primiano@chromium.org BUG=706874 Review-Url: https://codereview.chromium.org/2788723003 Cr-Commit-Position: refs/heads/master@{#461036} Committed: https://chromium.googlesource.com/chromium/src/+/ed4d42f1ac00b17cdb90417a87f03a15dc7553df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/trace_event/memory_dump_manager_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788723003/1
3 years, 8 months ago (2017-03-31 04:35:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ed4d42f1ac00b17cdb90417a87f03a15dc7553df
3 years, 8 months ago (2017-03-31 04:50:48 UTC) #5
Primiano Tucci (use gerrit)
3 years, 8 months ago (2017-03-31 09:20:04 UTC) #6
Message was sent while issue was closed.
Ehm, given that these were flaky only on iOS would have been nicer to disable
them only on that platform, not everywhere.

+hjd who was planning to disabled them on iOS only

Powered by Google App Engine
This is Rietveld 408576698