Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2788643003: [tools/perf] Remove remaining references to indexeddb_perf benchmark (Closed)

Created:
3 years, 8 months ago by perezju
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, shatch, scottmg
CC:
chromium-reviews, auto-bisect-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Remove remaining references to indexeddb_perf benchmark Benchmark does not exist any more. BUG=669832 Review-Url: https://codereview.chromium.org/2788643003 Cr-Commit-Position: refs/heads/master@{#461393} Committed: https://chromium.googlesource.com/chromium/src/+/2b8d3e9460b771a757adfc985fa4d1d19bd2d55c

Patch Set 1 #

Total comments: 2

Patch Set 2 : use speedometer as example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/win/run_pgo_profiling_benchmarks.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/auto_bisect/test_data/closed.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/docs/perf_bot_sheriffing.md View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
perezju
Please review changes: scottmg: build/win/run_pgo_profiling_benchmarks.py simonhatch: tools/auto_bisect/test_data/closed.json nednguyen: tools/perf/docs/perf_bot_sheriffing.md https://codereview.chromium.org/2788643003/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2788643003/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode347 tools/perf/docs/perf_bot_sheriffing.md:347: ...
3 years, 8 months ago (2017-03-31 12:18:26 UTC) #2
nednguyen
lgtm https://codereview.chromium.org/2788643003/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/2788643003/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode347 tools/perf/docs/perf_bot_sheriffing.md:347: `/usr/bin/python ../../testing/scripts/run_telemetry_benchmark_as_googletest.py ../../tools/perf/run_benchmark memory.desktop -v --upload-results --output-format=chartjson --browser=release ...
3 years, 8 months ago (2017-03-31 12:20:07 UTC) #3
shatch
lgtm
3 years, 8 months ago (2017-03-31 12:24:13 UTC) #4
scottmg
lgtm
3 years, 8 months ago (2017-03-31 17:49:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788643003/20001
3 years, 8 months ago (2017-04-03 08:00:30 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 09:34:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b8d3e9460b771a757adfc985fa4...

Powered by Google App Engine
This is Rietveld 408576698