Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2788633004: [sensors] Align Accelerometer interface with the specification (Closed)

Created:
3 years, 8 months ago by shalamov
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Align Accelerometer interface with the specification The accelerometer sensor interface was split into 3 separate sensors: Accelerometer, LinearAccelerationSensor and GravitySensor. Accelerometer provides low-level sensor data, while latter two, are fusion sensors and can be implemented using low-pass / high-pass filters and/or sensor fusion with other low-level sensors. https://w3c.github.io/accelerometer/#accelerometer-interface BUG=661478 Review-Url: https://codereview.chromium.org/2788633004 Cr-Commit-Position: refs/heads/master@{#461391} Committed: https://chromium.googlesource.com/chromium/src/+/d2c9e9c9cf5b680bf176400148452bf50b2d6ffd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -59 lines) Patch
M third_party/WebKit/LayoutTests/sensor/accelerometer.html View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.h View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.cpp View 3 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.idl View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AccelerometerOptions.idl View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
shalamov
ptal
3 years, 8 months ago (2017-03-31 09:29:06 UTC) #4
Mikhail
lgtm
3 years, 8 months ago (2017-03-31 11:25:16 UTC) #9
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-03-31 18:34:26 UTC) #11
haraken
LGTM
3 years, 8 months ago (2017-03-31 23:10:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788633004/1
3 years, 8 months ago (2017-04-03 07:48:54 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 09:23:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2c9e9c9cf5b680bf17640014845...

Powered by Google App Engine
This is Rietveld 408576698