Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2788603002: [turbofan] Disable inlining of derived class constructors. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin, gsathya
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable inlining of derived class constructors. The inlining logic doesn't account for the fact that the derived constructor could return a primitive, thus leaking the implicit receiver (which is the hole). R=jarin@chromium.org BUG=chromium:706642 Review-Url: https://codereview.chromium.org/2788603002 Cr-Commit-Position: refs/heads/master@{#44264} Committed: https://chromium.googlesource.com/v8/v8/+/c019e53cbb0e3249d28c2d88eca64bf73df8de56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-706642.js View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-03-30 09:54:19 UTC) #1
Benedikt Meurer
Disabling the optimization for now (back-mergable), so that we have time to really address the ...
3 years, 8 months ago (2017-03-30 09:55:59 UTC) #5
Jarin
lgtm
3 years, 8 months ago (2017-03-30 09:57:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788603002/1
3 years, 8 months ago (2017-03-30 09:58:10 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 10:17:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c019e53cbb0e3249d28c2d88eca64bf73df...

Powered by Google App Engine
This is Rietveld 408576698