Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2788593002: Remove |remote| and |readonly| members of MediaStreamTrack. (Closed)

Created:
3 years, 8 months ago by Yeol Park
Modified:
3 years, 8 months ago
CC:
avayvod+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, extensions-reviews_chromium.org, haraken, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jochen+watch_chromium.org, mac-reviews_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, tommyw+watchlist_chromium.org, xjz+watch_chromium.org, chrishtr, darin2, dglazkov, foolip, Rick Byers, tkent
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |remote| and |readonly| members of MediaStreamTrack. Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 removal was in the February 22, 2016'. [#321] Remove track attributes "remote" and "readonly" : https://github.com/w3c/mediacapture-main/pull/321 Intent to Deprecate and Remove : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI BUG=598704 Review-Url: https://codereview.chromium.org/2788593002 Cr-Commit-Position: refs/heads/master@{#460756} Committed: https://chromium.googlesource.com/chromium/src/+/bcc6621834abbd8f95c4d36e18d691ac495b0aa1

Patch Set 1 #

Patch Set 2 : Fixed webkit-tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -133 lines) Patch
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/renderer/media_stream_utils.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/renderer/media_stream_utils.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html View 1 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt View 1 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Yeol Park
PTAL :) jochen@ for chrome/renderer/extensions/* esprehn@ for content/renderer/* alexmos@ for content/public/renderer/* mkwst@ for content/shell/renderer/layout_test/* third_party/WebKit/LayoutTests/* ...
3 years, 8 months ago (2017-03-30 08:35:11 UTC) #3
Mike West
LGTM. Note that you'll need an API OWNER (like jochen@, CC'd) to stamp the change ...
3 years, 8 months ago (2017-03-30 10:40:30 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-30 11:51:05 UTC) #7
Guido Urdaneta
lgtm
3 years, 8 months ago (2017-03-30 11:53:03 UTC) #8
Yeol Park
+CC : third_party/WebKit/API_OWNERS
3 years, 8 months ago (2017-03-30 12:17:31 UTC) #9
foolip
lgtm
3 years, 8 months ago (2017-03-30 12:24:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788593002/20001
3 years, 8 months ago (2017-03-30 15:06:44 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/bcc6621834abbd8f95c4d36e18d691ac495b0aa1
3 years, 8 months ago (2017-03-30 15:12:50 UTC) #23
alexmos
3 years, 8 months ago (2017-03-30 16:26:47 UTC) #24
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698