content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc - Issue 2788583006: Delete content::MockURLRequestDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

Issue 2788583006: Delete content::MockURLRequestDelegate. (Closed)

Patch Set: Switch clients to net::TestDelegate instead of moving MockURLRequestDelegate. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/blob_storage/blob_url_request_job_unittest.cc ('K') | « content/browser/service_worker/service_worker_url_request_job_unittest.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

index 8fe5f13f38d34e2948aaff497c7edb957be78310..120ced710306bf9ac7201d9311a0e6ef07680c22 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

@@ -13,7 +13,6 @@

#include "base/run_loop.h"

#include "base/single_thread_task_runner.h"

#include "base/threading/thread_task_runner_handle.h"

-#include "content/browser/fileapi/mock_url_request_delegate.h"

#include "content/browser/service_worker/embedded_worker_test_helper.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_request_handler.h"

@@ -441,7 +440,7 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {

storage::BlobStorageContext blob_storage_context_;

content::MockResourceContext resource_context_;

- MockURLRequestDelegate url_request_delegate_;

+ net::TestDelegate url_request_delegate_;

int next_provider_id_ = 1;

int64_t next_version_id_ = 1L;

};