Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2788583002: Reland of "Make disabling 2d canvas GPU acceleration for getImageData less aggressive." (Closed)

Created:
3 years, 8 months ago by xiangze.zhang
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews, Rik, Stephen Chennney, fmalita+watch_chromium.org, haraken, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Make disabling 2d canvas GPU acceleration for getImageData less aggressive." Original patch https://codereview.chromium.org/2687073003/ reverted due to test regression. The test failure does not happen now. Make canvas switch out of gpu acceleration only when getImageData is called in successive frames. This will avoid disabling gpu acceleration when getImageData is only called once or is called very rarely. BUG=690122 Review-Url: https://codereview.chromium.org/2788583002 Cr-Commit-Position: refs/heads/master@{#461232} Committed: https://chromium.googlesource.com/chromium/src/+/9b1ac7f2a38585c066bc6523e0c08aeb1adbf171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 chunk +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 4 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xiangze.zhang
Since the AMD Linux test failure issue is fixed now, I'd like to re-land this ...
3 years, 8 months ago (2017-03-30 07:48:37 UTC) #2
Justin Novosad
lgtm
3 years, 8 months ago (2017-03-30 18:00:42 UTC) #3
xiangze.zhang
The workaround for the AMD driver bug does not work well and is reverted, but ...
3 years, 8 months ago (2017-03-31 08:19:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788583002/1
3 years, 8 months ago (2017-03-31 21:05:10 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 21:16:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b1ac7f2a38585c066bc6523e0c0...

Powered by Google App Engine
This is Rietveld 408576698