Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Issue 2788543002: Make mojo::internal::MultiplexRouter::InterfaceEndPoint RefCountedThreadSafe (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
gab, yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make mojo::internal::MultiplexRouter::InterfaceEndPoint RefCountedThreadSafe InterfaceEndPoint's ref count is a non-thread-safe, and is used behind a lock. The usage of it is not racy, but an upcoming change to add an assertion to RefCounted requires a suppression here. This CL converts InterfaceEndPoint to RefCountedThreadSafe, which doesn't need the suppression, regarding the atomic operations is lightweight comparing to a lock that covers the object itself, and RefCountedThreadSafe less error prone for cross thread usage. BUG=688072 Review-Url: https://codereview.chromium.org/2788543002 Cr-Commit-Position: refs/heads/master@{#460692} Committed: https://chromium.googlesource.com/chromium/src/+/b580fa032bb7a9d48c295f87cf69361a39e449b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
tzik
yzshen: PTAL. Can we use RefCountedThreadSafe here per http://crrev.com/2666423002/#msg181? gab: FYI.
3 years, 8 months ago (2017-03-30 05:31:25 UTC) #6
yzshen1
lgtm
3 years, 8 months ago (2017-03-30 05:54:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788543002/1
3 years, 8 months ago (2017-03-30 07:02:21 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 08:16:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b580fa032bb7a9d48c295f87cf69...

Powered by Google App Engine
This is Rietveld 408576698