third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp - Issue 2788523002: Finish all string attributes for Accessibility Object Model Phase 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

Issue 2788523002: Finish all string attributes for Accessibility Object Model Phase 1. (Closed)

Patch Set: Test that checked works with true/false, not only 'true' and 'false' Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/AccessibleNode.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

index db27248dfeec9904266e0b304201c2089fb57e33..67dd659bbf883fc1a8c32f3fd03ab68365429083 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

@@ -26,6 +26,7 @@

#include "modules/accessibility/AXMenuListOption.h"

#include "SkMatrix44.h"

+#include "core/dom/AccessibleNode.h"

#include "modules/accessibility/AXMenuListPopup.h"

#include "modules/accessibility/AXObjectCacheImpl.h"

@@ -47,7 +48,8 @@ void AXMenuListOption::detach() {

}

AccessibilityRole AXMenuListOption::roleValue() const {

- const AtomicString& ariaRole = getAttribute(roleAttr);

+ const AtomicString& ariaRole =

+ getAOMPropertyOrARIAAttribute(AOMStringProperty::kRole);

if (ariaRole.isEmpty())

return MenuListOptionRole;