Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2788523002: Finish all string attributes for Accessibility Object Model Phase 1. (Closed)
Patch Set: Test that checked works with true/false, not only 'true' and 'false' Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
index 73359759e1a26dc3c8f0988ada36871bbd1cb017..471f7ee117be500987b43451bbcd4a3d08550603 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -31,6 +31,7 @@
#include "bindings/core/v8/ExceptionState.h"
#include "core/CSSPropertyNames.h"
#include "core/InputTypeNames.h"
+#include "core/dom/AccessibleNode.h"
#include "core/dom/ElementTraversal.h"
#include "core/dom/Range.h"
#include "core/dom/shadow/ShadowRoot.h"
@@ -1323,7 +1324,8 @@ const AtomicString& AXLayoutObject::liveRegionStatus() const {
DEFINE_STATIC_LOCAL(const AtomicString, liveRegionStatusPolite, ("polite"));
DEFINE_STATIC_LOCAL(const AtomicString, liveRegionStatusOff, ("off"));
- const AtomicString& liveRegionStatus = getAttribute(aria_liveAttr);
+ const AtomicString& liveRegionStatus =
+ getAOMPropertyOrARIAAttribute(AOMStringProperty::kLive);
// These roles have implicit live region status.
if (liveRegionStatus.isEmpty()) {
switch (roleValue()) {
@@ -1347,7 +1349,8 @@ const AtomicString& AXLayoutObject::liveRegionStatus() const {
const AtomicString& AXLayoutObject::liveRegionRelevant() const {
DEFINE_STATIC_LOCAL(const AtomicString, defaultLiveRegionRelevant,
("additions text"));
- const AtomicString& relevant = getAttribute(aria_relevantAttr);
+ const AtomicString& relevant =
+ getAOMPropertyOrARIAAttribute(AOMStringProperty::kRelevant);
// Default aria-relevant = "additions text".
if (relevant.isEmpty())

Powered by Google App Engine
This is Rietveld 408576698