Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2788513002: DevTools: fix overlap in computed styles widget (Closed)

Created:
3 years, 8 months ago by luoe
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix overlap in computed styles widget Reorder the rule origin element to come after the selector element. BUG=662544 Review-Url: https://codereview.chromium.org/2788513002 Cr-Commit-Position: refs/heads/master@{#460931} Committed: https://chromium.googlesource.com/chromium/src/+/6970fa31e7037473ce71f9c2b870aca2a0952481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
luoe
Please take a look. The bug includes a screenshot of the bug, and the fix ...
3 years, 8 months ago (2017-03-30 02:54:56 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-03-30 20:10:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788513002/1
3 years, 8 months ago (2017-03-30 20:20:34 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 23:41:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6970fa31e7037473ce71f9c2b870...

Powered by Google App Engine
This is Rietveld 408576698