Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2788463005: Reland of Refactor WebUSB LayoutTests to separate out the Mojo service mocks (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
ortuno, yzshen1
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Refactor WebUSB LayoutTests to separate out the Mojo service mocks (patchset #1 id:1 of https://codereview.chromium.org/2791573002/ ) Reason for revert: Fixed the leak. Original issue's description: > Revert of Refactor WebUSB LayoutTests to separate out the Mojo service mocks (patchset #1 id:1 of https://codereview.chromium.org/2775323003/ ) > > Reason for revert: > Breaks leak bot: > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/3557 > > * usb/test-polyfil.html > * usb/usb-connection-event.html > * usb/usb.html > * usb/usbDevice-iframe.html > * usb/usbDevice.html > > seem to be leaking :( > > Original issue's description: > > Refactor WebUSB LayoutTests to separate out the Mojo service mocks > > > > In preparation for being able to upstream the existing WebUSB tests to > > the Web Platform Tests repository this patch splits out the Mojo > > service mocks into webusb-test.js. This file is a polyfil for a > > fictional "WebUSB Test API" that could in theory be implemented by any > > browser (an idea borrowed from a proposed plan for Web Bluetooth). > > > > BUG=705734 > > > > Review-Url: https://codereview.chromium.org/2775323003 > > Cr-Commit-Position: refs/heads/master@{#460978} > > Committed: https://chromium.googlesource.com/chromium/src/+/e1edfbbb4b3a192e210c031628e4f12aa93057cd > > TBR=yzshen@chromium.org,reillyg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=705734 > > Review-Url: https://codereview.chromium.org/2791573002 > Cr-Commit-Position: refs/heads/master@{#461045} > Committed: https://chromium.googlesource.com/chromium/src/+/245d44d8347cb000d4d78b46b9f120e3fc9f10d3 TBR=yzshen@chromium.org,ortuno@chromium.org BUG=705734 Review-Url: https://codereview.chromium.org/2788463005 Cr-Commit-Position: refs/heads/master@{#462203} Committed: https://chromium.googlesource.com/chromium/src/+/08513f9d231c07202bb6b2956f045f128950c194

Patch Set 1 #

Patch Set 2 : Register onunload handler to clear interface overrides #

Unified diffs Side-by-side diffs Delta from patch set Stats (+929 lines, -640 lines) Patch
D third_party/WebKit/LayoutTests/usb/mock-services.html View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/resources/fake-devices.js View 1 1 chunk +89 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 1 3 chunks +32 lines, -416 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/resources/webusb-test.js View 1 1 chunk +569 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/usb/test-polyfil.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/usb.html View 1 7 chunks +32 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/usb-connection-event.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/usbDevice.html View 1 34 chunks +133 lines, -96 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/usbDevice-iframe.html View 1 1 chunk +60 lines, -67 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Reilly Grant (use Gerrit)
Created Reland of actor WebUSB LayoutTests to separate out the Mojo service mocks
3 years, 8 months ago (2017-03-31 20:53:42 UTC) #1
Reilly Grant (use Gerrit)
Register onunload handler to clear interface overrides
3 years, 8 months ago (2017-03-31 20:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788463005/240001
3 years, 8 months ago (2017-04-05 19:27:05 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 20:37:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/08513f9d231c07202bb6b2956f04...

Powered by Google App Engine
This is Rietveld 408576698