Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2788443003: [History service] Fix wrong thread used for SetLastResortFavicon (Closed)

Created:
3 years, 8 months ago by jkrcal
Modified:
3 years, 8 months ago
Reviewers:
mastiz, sky, sdefresne
CC:
mastinoz
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[History service] Fix a typo in SetLastResortFavicons Previously, backend task were not performed on the right thread which caused a crash in debug-build. This CL assigns the task to the the right task runner. BUG=644102 Review-Url: https://codereview.chromium.org/2788443003 Cr-Commit-Position: refs/heads/master@{#461124} Committed: https://chromium.googlesource.com/chromium/src/+/9113ea78bc7a96ef8ba2b89a26aafd2fbc0b55e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/history/core/browser/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
jkrcal
Scott, could you PTAL? Mikel, just double-checking that this "mistake" was not intentional.
3 years, 8 months ago (2017-03-30 16:27:21 UTC) #2
mastiz
LGTM. Thanks Jan for fixing this! Another concern comes to mind: none of these functions ...
3 years, 8 months ago (2017-03-31 06:58:02 UTC) #7
jkrcal
Sylvain, could you please take an owners look? (I would like to land this and ...
3 years, 8 months ago (2017-03-31 07:13:26 UTC) #9
sky
LGTM
3 years, 8 months ago (2017-03-31 14:25:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788443003/1
3 years, 8 months ago (2017-03-31 15:03:12 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 15:09:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9113ea78bc7a96ef8ba2b89a26aa...

Powered by Google App Engine
This is Rietveld 408576698