Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2788403002: Revert of Introduce InterfaceEndpointClient(IEC), InterfaceEndpointHandle and (Closed)

Created:
3 years, 8 months ago by kolos1
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, Eugene But (OOO till 7-30), extensions-reviews_chromium.org, jam, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce InterfaceEndpointClient(IEC), InterfaceEndpointHandle and (patchset #14 id:260001 of https://codereview.chromium.org/2744963002/ ) Reason for revert: This CL makes BluetoothInternalsTest.Startup_BluetoothInternals flaky. See FindIt report https://findit-for-me.appspot.com/waterfall/failure?url=https%3A%2F%2Fbuild.chromium.org%2Fp%2Fchromium.linux%2Fbuilders%2FLinux%2520Tests%2520%2528dbg%2529%25281%2529%252832%2529%2Fbuilds%2F39814 Also check details in the bug. BUG=707725 Original issue's description: > Introduce InterfaceEndpointClient(IEC), InterfaceEndpointHandle and > PipeControlMessage Handler/Proxy. Move accept message and handling code from > Router to IEC. There is still only 1 interface on a message pipe, but this > work helps setup for associated interfaces. > > BUG=695635 > > Review-Url: https://codereview.chromium.org/2744963002 > Cr-Commit-Position: refs/heads/master@{#460817} > Committed: https://chromium.googlesource.com/chromium/src/+/087549eb773ef4b5fd43b5bd57f1a9ddfceeb486 TBR=rockot@chromium.org,eugenebut@chromium.org,jam@chromium.org,yzshen@chromium.org,wangjimmy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=695635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -1071 lines) Patch
M content/content_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/mojo_context_state.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/web/ios_web_resources.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 1 chunk +0 lines, -11 lines 0 comments Download
M ios/web/webui/mojo_js_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/webui/mojo_js_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/webui/resources/console.js View 1 chunk +2 lines, -4 lines 0 comments Download
D ios/web/webui/resources/timer.js View 1 chunk +0 lines, -38 lines 0 comments Download
M mojo/edk/js/tests/run_js_unittests.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/js/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/public/js/bindings.js View 12 chunks +27 lines, -64 lines 0 comments Download
M mojo/public/js/codec.js View 3 chunks +4 lines, -8 lines 0 comments Download
M mojo/public/js/connector.js View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/public/js/constants.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/js/constants.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/public/js/interface_types.js View 2 chunks +0 lines, -18 lines 0 comments Download
M mojo/public/js/lib/control_message_handler.js View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/js/lib/control_message_proxy.js View 3 chunks +11 lines, -13 lines 0 comments Download
D mojo/public/js/lib/interface_endpoint_client.js View 1 chunk +0 lines, -232 lines 0 comments Download
D mojo/public/js/lib/interface_endpoint_handle.js View 1 chunk +0 lines, -158 lines 0 comments Download
D mojo/public/js/lib/pipe_control_message_handler.js View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/public/js/lib/pipe_control_message_proxy.js View 1 chunk +0 lines, -56 lines 0 comments Download
M mojo/public/js/router.js View 1 chunk +173 lines, -239 lines 0 comments Download
M mojo/public/js/tests/validation_unittest.js View 3 chunks +9 lines, -5 lines 0 comments Download
M mojo/public/js/validator.js View 3 chunks +0 lines, -48 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/mojo/binding.html View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/mojo/connection.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/mojo/interface_ptr.html View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kolos1
Created Revert of Introduce InterfaceEndpointClient(IEC), InterfaceEndpointHandle and
3 years, 8 months ago (2017-04-03 10:56:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788403002/1
3 years, 8 months ago (2017-04-03 10:56:26 UTC) #3
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-03 16:53:21 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698