Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2788393003: Add color profile testing/libfuzzer/fuzzers/dicts/icc.dict (Closed)

Created:
3 years, 8 months ago by Noel Gordon
Modified:
3 years, 8 months ago
Reviewers:
mmoroz, inferno
CC:
chromium-reviews, fuzzing_chromium.org, scroggo, inferno
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add color profile testing/libfuzzer/fuzzers/dicts/icc.dict Add a dictionary of token symbols for ICC color profiles to be used to guide LLVM fuzzing of profiles and transforms. BUG=708016 Review-Url: https://codereview.chromium.org/2788393003 Cr-Commit-Position: refs/heads/master@{#461603} Committed: https://chromium.googlesource.com/chromium/src/+/7e5e257471e768f38f03163d6e0e3780e7c11211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
A testing/libfuzzer/fuzzers/dicts/icc.dict View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Noel Gordon
PTAL.
3 years, 8 months ago (2017-04-04 01:14:15 UTC) #5
inferno
You need the accompanying BUILD.gn side change as well. E.g. see https://cs.chromium.org/chromium/src/pdf/pdfium/fuzzers/BUILD.gn?rcl=3ba57766474b9e525e858ae8382d8acbdec34039&l=67
3 years, 8 months ago (2017-04-04 01:21:10 UTC) #10
Noel Gordon
Don't need a BUILD.gn change yet, (need to write a fuzzer first, right?).
3 years, 8 months ago (2017-04-04 01:22:44 UTC) #11
inferno
ok fine lgtm.
3 years, 8 months ago (2017-04-04 01:24:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788393003/1
3 years, 8 months ago (2017-04-04 01:26:06 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 01:35:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e5e257471e768f38f03163d6e0e...

Powered by Google App Engine
This is Rietveld 408576698