Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Issue 2788343003: Remove desired DPI (Closed)

Created:
3 years, 8 months ago by rbpotter
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove desired DPI Desired DPI is only used to convert from DPI to points per inch and is hardcoded at 72. Instead use kPointsPerInch for the conversion and remove desired dpi. BUG=None Review-Url: https://codereview.chromium.org/2788343003 Cr-Commit-Position: refs/heads/master@{#461526} Committed: https://chromium.googlesource.com/chromium/src/+/de17410e0439acd489df4d5118e2e3deae88d3b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -41 lines) Patch
M components/printing/browser/print_manager_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/printing/common/print_messages.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 2 chunks +20 lines, -21 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/printing/test/mock_printer.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M printing/print_settings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M printing/print_settings_conversion.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
rbpotter
3 years, 8 months ago (2017-04-03 18:35:10 UTC) #5
Lei Zhang
lgtm
3 years, 8 months ago (2017-04-03 18:38:13 UTC) #6
rbpotter
3 years, 8 months ago (2017-04-03 18:44:13 UTC) #8
Tom Sepez
RS LGTM on deleting member from message.
3 years, 8 months ago (2017-04-03 19:01:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788343003/1
3 years, 8 months ago (2017-04-03 20:30:54 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 20:48:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de17410e0439acd489df4d5118e2...

Powered by Google App Engine
This is Rietveld 408576698