Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.h

Issue 2788283002: Fix PrintPreviewDestinationSearchTest.Select (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/print_preview_destination_search_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
index 143917b9d0f3de954859dc616a5eeda8b4ff4bc6..e061df993e85ec38891ed30d97d1f0be61c3d09b 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
@@ -175,20 +175,20 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {
PrintPreviewHandler* handler_;
// Indicates whether the source document can be modified.
- bool source_is_modifiable_;
+ bool source_is_modifiable_ = false;
Lei Zhang 2017/04/03 20:32:42 This is also being set in the constructor... to tr
skau 2017/04/04 17:37:02 Done.
// Indicates whether the source document has selection.
- bool source_has_selection_;
+ bool source_has_selection_ = false;
// Indicates whether only the selection should be printed.
- bool print_selection_only_;
+ bool print_selection_only_ = false;
Lei Zhang 2017/04/03 20:32:42 This is the missing initialization. Let's move it
skau 2017/04/04 17:37:02 Done.
// Store the initiator title, used for populating the print preview dialog
// title.
base::string16 initiator_title_;
// Keeps track of whether OnClosePrintPreviewDialog() has been called or not.
- bool dialog_closed_;
+ bool dialog_closed_ = false;
DISALLOW_COPY_AND_ASSIGN(PrintPreviewUI);
};
« no previous file with comments | « no previous file | chrome/test/data/webui/print_preview_destination_search_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698