Fix PrintPreviewDestinationSearchTest.Select

chrome/browser/ui/webui/print_preview/print_preview_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_UI_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 157 matching lines @@
   base::TimeTicks initial_preview_start_time_;
 
   // The unique ID for this class instance. Stored here to avoid calling
   // GetIDForPrintPreviewUI() everywhere.
   const int32_t id_;
 
   // Weak pointer to the WebUI handler.
   PrintPreviewHandler* handler_;
 
   // Indicates whether the source document can be modified.
-  bool source_is_modifiable_;
+  bool source_is_modifiable_ = false;

[Lei Zhang, 2017/04/03 20:32:42]

This is also being set in the constructor... to true. Can we leave this alone?
It's clearly not the cause of the uninit error.

[skau, 2017/04/04 17:37:02]

Done.

 
   // Indicates whether the source document has selection.
-  bool source_has_selection_;
+  bool source_has_selection_ = false;
 
   // Indicates whether only the selection should be printed.
-  bool print_selection_only_;
+  bool print_selection_only_ = false;

[Lei Zhang, 2017/04/03 20:32:42]

This is the missing initialization. Let's move it to the ctor for consistency
with the rest.

[skau, 2017/04/04 17:37:02]

Done.

 
   // Store the initiator title, used for populating the print preview dialog
   // title.
   base::string16 initiator_title_;
 
   // Keeps track of whether OnClosePrintPreviewDialog() has been called or not.
-  bool dialog_closed_;
+  bool dialog_closed_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewUI);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_UI_H_