Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2788263002: Fix tablet input mode test (Closed)

Created:
3 years, 8 months ago by mdjones
Modified:
3 years, 8 months ago
Reviewers:
Ted C, Maria
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tablet input mode test Update LocationBarTablet to match the soft input mode that LocationBarPhone uses (SOFT_INPUT_ADJUST_RESIZE to SOFT_INPUT_ADJUST_NOTHING). BUG=707383 Review-Url: https://codereview.chromium.org/2788263002 Cr-Commit-Position: refs/heads/master@{#461302} Committed: https://chromium.googlesource.com/chromium/src/+/f0433e75d2158112feb6be25d52c60d0c7f80e77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mdjones
ptal
3 years, 8 months ago (2017-03-31 23:57:05 UTC) #2
Maria
lgtm
3 years, 8 months ago (2017-04-01 00:51:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788263002/1
3 years, 8 months ago (2017-04-01 00:51:58 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 01:36:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0433e75d2158112feb6be25d52c...

Powered by Google App Engine
This is Rietveld 408576698