Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2788213002: Rebaseline 2 transforms/3d tests (Closed)

Created:
3 years, 8 months ago by Stephen Chennney
Modified:
3 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline 2 transforms/3d tests Both transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html and transforms/3d/point-mapping/3d-point-mapping-deep.html are marked as flakey or failing, but we can't tell if that's the case without rebaselining. So do that and see what happens. TBR=danakj@chromium.org BUG=606302 Review-Url: https://codereview.chromium.org/2788213002 Cr-Commit-Position: refs/heads/master@{#461771} Committed: https://chromium.googlesource.com/chromium/src/+/daebb5887b27f4a4f0a09b9920cb1db86b379459

Patch Set 1 #

Patch Set 2 : New baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -142 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt View 1 1 chunk +34 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt View 1 1 chunk +69 lines, -69 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt View 1 2 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788213002/20001
3 years, 8 months ago (2017-04-04 16:27:44 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/daebb5887b27f4a4f0a09b9920cb1db86b379459
3 years, 8 months ago (2017-04-04 18:19:02 UTC) #5
Max Morin
3 years, 8 months ago (2017-04-05 06:19:40 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2798833002/ by maxmorin@chromium.org.

The reason for reverting is: Appears to cause failures on win 7 webkit bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698