Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2788083003: Really disable symbols on the ToT Windows LLD bots (Closed)

Created:
3 years, 8 months ago by Reid Kleckner
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Really disable symbols on the ToT Windows LLD bots The default symbol_level on Windows is 2, not 0, so these bots are still red because they are trying to produce PDBs. TBR=thakis@chromium.org BUG=706492 NOTRY=true Review-Url: https://codereview.chromium.org/2788083003 Cr-Commit-Position: refs/heads/master@{#461163} Committed: https://chromium.googlesource.com/chromium/src/+/96c9dd773e020fea6294fc80bad1bcccb7deb05d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Reid Kleckner
3 years, 8 months ago (2017-03-31 17:28:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788083003/1
3 years, 8 months ago (2017-03-31 17:29:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/96c9dd773e020fea6294fc80bad1bcccb7deb05d
3 years, 8 months ago (2017-03-31 17:38:01 UTC) #6
Nico
3 years, 8 months ago (2017-03-31 17:43:52 UTC) #7
Message was sent while issue was closed.
Doh sorry, I knew that. Lgtm.

Powered by Google App Engine
This is Rietveld 408576698