Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 2788033002: [es2015] Simplify contract between parser and stub for derived constructors. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Yang, marja
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[es2015] Simplify contract between parser and stub for derived constructors. Rewrite returns in derived constructors to only replace undefined with this, and otherwise just return the value, and let the construct stub builtin throw an exception if the result is a primitive instead of a JSReceiver. R=yangguo@chromium.org TBR=marja@chromium.org BUG=chromium:706642 Review-Url: https://codereview.chromium.org/2788033002 Cr-Commit-Position: refs/heads/master@{#44288} Committed: https://chromium.googlesource.com/v8/v8/+/776d89f9ce6e043972c1e611aa8cfaf2feb1fb78

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Manual register allocation... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -34 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +7 lines, -20 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Benedikt Meurer
3 years, 8 months ago (2017-03-31 05:09:46 UTC) #1
Yang
On 2017/03/31 05:09:46, Benedikt Meurer wrote: lgtm.
3 years, 8 months ago (2017-03-31 05:11:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788033002/20001
3 years, 8 months ago (2017-03-31 05:12:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/19396) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-03-31 05:34:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788033002/40001
3 years, 8 months ago (2017-03-31 05:38:58 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 06:01:09 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/776d89f9ce6e043972c1e611aa8cfaf2feb...

Powered by Google App Engine
This is Rietveld 408576698