[Home] Disable composited progress bar

[Home] Disable composited progress bar

When Chrome Home is enabled, the progress bar is no longer part of
the toolbar; it is at the top of the screen and does not move relative
to the toolbar. This change disables updates to the composited
progress bar when Chrome Home is enabled since it is unnecessary and
positioned incorrectly.

BUG=706686
Review-Url: https://codereview.chromium.org/2787983002
Cr-Commit-Position: refs/heads/master@{#461289}
Committed: https://chromium.googlesource.com/chromium/src/+/b332a9d54d5e06c6013c293e293f625f840d711d

[mdjones, 2017-03-31 00:17:32]

mdjones@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[mdjones, 2017-03-31 00:17:32]

ptal

[Khushal, 2017-03-31 00:46:12]

https://codereview.chromium.org/2787983002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java
(right):

https://codereview.chromium.org/2787983002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java:105:
if (mProgressBarDrawingInfo != null &&
!fullscreenManager.areBrowserControlsAtBottom()) {
Move this up with the other check for isTablet?
if (!isTablet && isChromeHome && ...)

[Khushal, 2017-03-31 00:46:57]

https://codereview.chromium.org/2787983002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java
(right):

https://codereview.chromium.org/2787983002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java:105:
if (mProgressBarDrawingInfo != null &&
!fullscreenManager.areBrowserControlsAtBottom()) {
On 2017/03/31 00:46:12, Khushal wrote:
> Move this up with the other check for isTablet?
> if (!isTablet && isChromeHome && ...)

I meant !isChromeHome. :P

[mdjones, 2017-03-31 15:42:33]

Got any lgtms I can have?

https://codereview.chromium.org/2787983002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java
(right):

https://codereview.chromium.org/2787983002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java:105:
if (mProgressBarDrawingInfo != null &&
!fullscreenManager.areBrowserControlsAtBottom()) {
On 2017/03/31 00:46:57, Khushal wrote:
> On 2017/03/31 00:46:12, Khushal wrote:
> > Move this up with the other check for isTablet?
> > if (!isTablet && isChromeHome && ...)
> 
> I meant !isChromeHome. :P

Done.

[Khushal, 2017-03-31 21:34:12]

lgtm

[mdjones, 2017-03-31 23:59:42]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2017-04-01 00:00:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 00:42:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491004782042420,
"parent_rev": "b9b288099355aef2d3eaf8593ce6454187546594", "commit_rev":
"b332a9d54d5e06c6013c293e293f625f840d711d"}

[commit-bot: I haz the power, 2017-04-01 00:42:57]

Description was changed from

==========
[Home] Disable composited progress bar

When Chrome Home is enabled, the progress bar is no longer part of
the toolbar; it is at the top of the screen and does not move relative
to the toolbar. This change disables updates to the composited
progress bar when Chrome Home is enabled since it is unnecessary and
positioned incorrectly.

BUG=706686
==========

to

==========
[Home] Disable composited progress bar

When Chrome Home is enabled, the progress bar is no longer part of
the toolbar; it is at the top of the screen and does not move relative
to the toolbar. This change disables updates to the composited
progress bar when Chrome Home is enabled since it is unnecessary and
positioned incorrectly.

BUG=706686

Review-Url: https://codereview.chromium.org/2787983002
Cr-Commit-Position: refs/heads/master@{#461289}
Committed:
https://chromium.googlesource.com/chromium/src/+/b332a9d54d5e06c6013c293e293f...
==========

[commit-bot: I haz the power, 2017-04-01 00:42:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b332a9d54d5e06c6013c293e293f...