Roll lss 3f6478ac:63f24c82

Roll lss 3f6478ac:63f24c82

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..63f24c82

63f24c8 Revert "Put r7 back into clobber registers in sys_clone() for thumb2."
a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
TBR=mseaborn

Review-Url: https://codereview.chromium.org/2787843002
Cr-Commit-Position: refs/heads/master@{#460971}
Committed: https://chromium.googlesource.com/chromium/src/+/682407636255b8a85f4ae4a7646d534184a032a5

[Nico, 2017-03-30 15:08:44]

Description was changed from

==========
Roll lss 3f6478ac:a2b70922

BUG=507717
==========

to

==========
Roll lss 3f6478ac:a2b70922

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..a2b70922

a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
==========

[Nico, 2017-03-30 15:08:59]

Description was changed from

==========
Roll lss 3f6478ac:a2b70922

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..a2b70922

a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
==========

to

==========
Roll lss 3f6478ac:a2b70922

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..a2b70922

a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
TBR=mseaborn
==========

[Nico, 2017-03-30 15:09:10]

thakis@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Nico, 2017-03-30 15:10:43]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-30 15:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 15:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 15:54:03]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Mark Seaborn, 2017-03-30 17:29:41]

On 2017/03/30 15:54:03, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

Looks like this one failed with Android's GCC:
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

The error is:
../../breakpad/src/client/linux/handler/exception_handler.cc:554:1: error: r7
cannot be used in asm here

I should have asked the author of that change to roll it into Chromium when they
landed it.  Maybe we should set up an auto-roller for LSS.

Do you want to revert that change?

[Nico, 2017-03-30 17:30:36]

On Thu, Mar 30, 2017 at 1:29 PM, <mseaborn@chromium.org> wrote:

> On 2017/03/30 15:54:03, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> > android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
> >
> https://build.chromium.org/p/tryserver.chromium.android/
> builders/android_compile_dbg/builds/239125)
>
> Looks like this one failed with Android's GCC:
> 1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.
>
> The error is:
> ../../breakpad/src/client/linux/handler/exception_handler.cc:554:1:
> error: r7
> cannot be used in asm here
>
> I should have asked the author of that change to roll it into Chromium
> when they
> landed it. Maybe we should set up an auto-roller for LSS.
>
> Do you want to revert that change?
>

I left a similar comment on
https://codereview.chromium.org/1903833002/#msg13

I'll prepare a revert.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-03-30 17:42:30]

I put a revert here https://chromium-review.googlesource.com/c/463646/ For
some reason, I'm not able to put you as reviewer. Please review it.

On Thu, Mar 30, 2017 at 1:30 PM, Nico Weber <thakis@chromium.org> wrote:

> On Thu, Mar 30, 2017 at 1:29 PM, <mseaborn@chromium.org> wrote:
>
>> On 2017/03/30 15:54:03, commit-bot: I haz the power wrote:
>> > Try jobs failed on following builders:
>> > android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
>> >
>> https://build.chromium.org/p/tryserver.chromium.android/buil
>> ders/android_compile_dbg/builds/239125)
>>
>> Looks like this one failed with Android's GCC:
>> 1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.
>>
>> The error is:
>> ../../breakpad/src/client/linux/handler/exception_handler.cc:554:1:
>> error: r7
>> cannot be used in asm here
>>
>> I should have asked the author of that change to roll it into Chromium
>> when they
>> landed it. Maybe we should set up an auto-roller for LSS.
>>
>> Do you want to revert that change?
>>
>
> I left a similar comment on https://codereview.chromium.
> org/1903833002/#msg13
>
> I'll prepare a revert.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-03-30 19:11:04]

Description was changed from

==========
Roll lss 3f6478ac:a2b70922

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..a2b70922

a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
TBR=mseaborn
==========

to

==========
Roll lss 3f6478ac:63f24c82

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..63f24c82

63f24c8 Revert "Put r7 back into clobber registers in sys_clone() for thumb2."
a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
TBR=mseaborn
==========

[Nico, 2017-03-30 19:11:11]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-30 19:12:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 22:39:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:39:40]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nico, 2017-03-30 23:58:03]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:58:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 01:11:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490918283693810,
"parent_rev": "a98813b529a60bebc96f001559804652630be7c3", "commit_rev":
"682407636255b8a85f4ae4a7646d534184a032a5"}

[commit-bot: I haz the power, 2017-03-31 01:12:10]

Description was changed from

==========
Roll lss 3f6478ac:63f24c82

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..63f24c82

63f24c8 Revert "Put r7 back into clobber registers in sys_clone() for thumb2."
a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
TBR=mseaborn
==========

to

==========
Roll lss 3f6478ac:63f24c82

https://chromium.googlesource.com/linux-syscall-support/+log/3f6478ac..63f24c82

63f24c8 Revert "Put r7 back into clobber registers in sys_clone() for thumb2."
a2b7092 Fix -Wshift-negative-value warnings with MAKE_PROCESS_CPUCLOCK.
c555f53 Fix armv8/thumb IT blocks
5cedb6b Switch LSS to use Gerrit for code review by default
1549d20 Put r7 back into clobber registers in sys_clone() for thumb2.

BUG=507717
TBR=mseaborn

Review-Url: https://codereview.chromium.org/2787843002
Cr-Commit-Position: refs/heads/master@{#460971}
Committed:
https://chromium.googlesource.com/chromium/src/+/682407636255b8a85f4ae4a7646d...
==========

[commit-bot: I haz the power, 2017-03-31 01:12:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/682407636255b8a85f4ae4a7646d...