Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2787823004: memory-infra: Disable two MemoryDumpManager tests on iOS (Closed)

Created:
3 years, 8 months ago by hjd
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: Disable two MemoryDumpManager tests on iOS The tests seem to be flaky and we are about to restructure the MemoryDumpManager to not know about tracing so it doesn't seem worth hunting down the cause. R=primiano@chromium.org BUG=706961 Review-Url: https://codereview.chromium.org/2787823004 Cr-Commit-Position: refs/heads/master@{#461093} Committed: https://chromium.googlesource.com/chromium/src/+/9770fad0b3ebe389c34672dc8797bf8fbffeda9b

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : add a missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M base/trace_event/memory_dump_manager_unittest.cc View 1 2 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hjd
ptal, thanks!
3 years, 8 months ago (2017-03-31 09:41:49 UTC) #2
Primiano Tucci (use gerrit)
LGTM with one comment, thanks https://codereview.chromium.org/2787823004/diff/20001/base/trace_event/memory_dump_manager_unittest.cc File base/trace_event/memory_dump_manager_unittest.cc (right): https://codereview.chromium.org/2787823004/diff/20001/base/trace_event/memory_dump_manager_unittest.cc#newcode35 base/trace_event/memory_dump_manager_unittest.cc:35: #include "testing/gmock/include/gmock/gmock.h" plz ad ...
3 years, 8 months ago (2017-03-31 09:59:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787823004/40001
3 years, 8 months ago (2017-03-31 10:24:37 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 10:37:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9770fad0b3ebe389c34672dc8797...

Powered by Google App Engine
This is Rietveld 408576698