Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2787823002: Rephrased documentation about VTT, ::cue, and custom pseudo scopes. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, kochi
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rephrased documentation about VTT, ::cue, and custom pseudo scopes. We should not make these rules part of boundary crossing rules as they will go away when Shadow DOM v0 goes away. Adjusted the documentation to not hint in that direction. R=kochi@chromium.org,meade@chromium.org BUG=551751 Review-Url: https://codereview.chromium.org/2787823002 Cr-Commit-Position: refs/heads/master@{#461059} Committed: https://chromium.googlesource.com/chromium/src/+/e714f2ca03dd306dc98407c09229987cfef24ba0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rune
ptal
3 years, 8 months ago (2017-03-30 13:16:35 UTC) #2
meade_UTC10
lgtm
3 years, 8 months ago (2017-03-31 04:24:15 UTC) #6
kochi
LGTM
3 years, 8 months ago (2017-03-31 05:14:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787823002/1
3 years, 8 months ago (2017-03-31 06:35:34 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 06:41:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e714f2ca03dd306dc98407c09229...

Powered by Google App Engine
This is Rietveld 408576698