Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Issue 2787813002: memory-infra: remove debugging flow-events (Closed)

Created:
3 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

memory-infra: remove debugging flow-events The Trace Viewer UI can hang / OOM if the flow events are not consistent. Very likely this started happening after memory-infra started supported queueing of memory dump requests. Flow events never added too much value, so ditching them to avoid UI issues. Also this CL switches to the new TRACE_ID_LOCAL trace macro for the remaining debugging events. BUG=706042 Review-Url: https://codereview.chromium.org/2778743005 Cr-Commit-Position: refs/heads/master@{#460238} (cherry picked from commit 21ea0c9b1eb01f5cd463d812c6b9a759d5227239) Review-Url: https://codereview.chromium.org/2787813002 . Cr-Commit-Position: refs/branch-heads/3029@{#487} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e3f707396bb17792de4f3b901b5766dae64b8013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M base/trace_event/memory_dump_manager.cc View 8 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Primiano Tucci (use gerrit)
3 years, 8 months ago (2017-03-30 13:04:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3f707396bb17792de4f3b901b5766dae64b8013.

Powered by Google App Engine
This is Rietveld 408576698