Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2787783002: Resolve preloadResponse of Navigation Preload even if the response body is empty. (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, blink-reviews, kinuko+serviceworker, horo+watch_chromium.org, haraken, darin-cc_chromium.org, kinuko+watch, tzik, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Resolve preloadResponse of Navigation Preload even if the response body is empty. BUG=706765 TEST=virtual/service-worker-navigation-preload-wpt/external/wpt/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html Review-Url: https://codereview.chromium.org/2787783002 Cr-Commit-Position: refs/heads/master@{#461082} Committed: https://chromium.googlesource.com/chromium/src/+/f37399e1cb91a70730938f61008142ce61a00ad6

Patch Set 1 #

Patch Set 2 : move to wpt test #

Messages

Total messages: 26 (19 generated)
horo
falken@ Could you please review this?
3 years, 8 months ago (2017-03-30 11:36:18 UTC) #10
falken
I tend to prefer the layout test to browser tests. Is it possible to test ...
3 years, 8 months ago (2017-03-31 01:41:17 UTC) #13
horo
On 2017/03/31 01:41:17, falken wrote: > I tend to prefer the layout test to browser ...
3 years, 8 months ago (2017-03-31 06:05:21 UTC) #16
falken
lgtm, thank you
3 years, 8 months ago (2017-03-31 07:26:24 UTC) #20
falken
lgtm, thank you
3 years, 8 months ago (2017-03-31 07:26:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787783002/60001
3 years, 8 months ago (2017-03-31 07:34:28 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 08:57:59 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f37399e1cb91a70730938f610081...

Powered by Google App Engine
This is Rietveld 408576698