Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2787763002: Add autolayout height constraint on ReadingListCell (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
Olivier
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add autolayout height constraint on ReadingListCell This CL adds a fix height constraint on the ReadingListCell, allowing them to be used in a dynamically determined height collection. BUG=none Review-Url: https://codereview.chromium.org/2787763002 Cr-Commit-Position: refs/heads/master@{#460714} Committed: https://chromium.googlesource.com/chromium/src/+/843a95b06e362f496929c6edc0b700f150180a97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
gambard
PTAL.
3 years, 8 months ago (2017-03-30 09:37:16 UTC) #2
Olivier
lgtm
3 years, 8 months ago (2017-03-30 09:45:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787763002/1
3 years, 8 months ago (2017-03-30 09:48:47 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 10:13:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/843a95b06e362f496929c6edc0b7...

Powered by Google App Engine
This is Rietveld 408576698