Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2787743002: Add use counters for elements used in Shadow DOM (Closed)

Created:
3 years, 8 months ago by hayato
Modified:
3 years, 8 months ago
Reviewers:
haraken, tkent
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for elements used in Shadow DOM BUG=489947 TBR=haraken Review-Url: https://codereview.chromium.org/2787743002 Cr-Commit-Position: refs/heads/master@{#461080} Committed: https://chromium.googlesource.com/chromium/src/+/f7e2cfea3cf9c671edd9c2dfc1feabc2d44671de

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLContentElement.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLShadowElement.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (25 generated)
hayato
PTAL
3 years, 8 months ago (2017-03-30 08:28:07 UTC) #5
tkent
lgtm
3 years, 8 months ago (2017-03-30 08:42:07 UTC) #8
hayato
rebased
3 years, 8 months ago (2017-03-30 08:58:20 UTC) #9
hayato
haraken@, could you review for histograms.xml?
3 years, 8 months ago (2017-03-30 09:01:44 UTC) #13
hayato
TBR=haraken
3 years, 8 months ago (2017-03-30 09:04:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787743002/20001
3 years, 8 months ago (2017-03-30 09:05:13 UTC) #19
haraken
LGTM
3 years, 8 months ago (2017-03-30 09:30:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/394680)
3 years, 8 months ago (2017-03-30 11:22:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787743002/20001
3 years, 8 months ago (2017-03-31 05:19:03 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/399623)
3 years, 8 months ago (2017-03-31 05:26:00 UTC) #26
hayato
rebased
3 years, 8 months ago (2017-03-31 05:42:17 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787743002/40001
3 years, 8 months ago (2017-03-31 05:43:29 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/184382)
3 years, 8 months ago (2017-03-31 06:40:21 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787743002/40001
3 years, 8 months ago (2017-03-31 07:39:07 UTC) #37
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 08:42:17 UTC) #40
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7e2cfea3cf9c671edd9c2dfc1fe...

Powered by Google App Engine
This is Rietveld 408576698