[Workaround] Notify Overscroll Actions that a gesture ended.

ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include <algorithm>
 #include "base/logging.h"
 #include "base/mac/objc_property_releaser.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/metrics/histogram_macros.h"
 #import "ios/chrome/browser/ui/browser_view_controller.h"
+#import "ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.h"
 #import "ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.h"
 #include "ios/chrome/browser/ui/rtl_geometry.h"
 #import "ios/chrome/browser/ui/toolbar/toolbar_controller.h"
 #import "ios/chrome/browser/ui/toolbar/web_toolbar_controller.h"
 #include "ios/chrome/browser/ui/uikit_ui_util.h"
 #import "ios/chrome/browser/ui/voice/voice_search_notification_names.h"
 #import "ios/web/public/web_state/ui/crw_web_view_proxy.h"
 
 namespace {
 // This enum is used to record the overscroll actions performed by the user on
@@ skipping 543 matching lines @@
                  name:UIDeviceOrientationDidChangeNotification
                object:nil];
 }
 
 - (void)tearDown {
   [[self scrollView] removeGestureRecognizer:self.panGestureRecognizer];
   self.panGestureRecognizer = nil;
 }
 
 - (void)setup {
-  base::scoped_nsobject<UIPanGestureRecognizer> panGesture(
-      [[UIPanGestureRecognizer alloc] initWithTarget:self
-                                              action:@selector(panGesture:)]);
+  base::scoped_nsobject<UIPanGestureRecognizer> panGesture;
+  // Workaround a bug occuring when Speak Selection is enabled.
+  // See crbug.com/699655.
+  if (UIAccessibilityIsSpeakSelectionEnabled()) {

[justincohen, 2017/04/05 14:22:07]

Does -setup only get called once per process start?  Do we care if someone
enables speak selection after the app start?  Even if the answer is, I like that
this fix minimizes it's impact only to speak selection enabled...

+    panGesture.reset([[OverscrollActionsGestureRecognizer alloc]
+        initWithTarget:self
+                action:@selector(panGesture:)]);
+  } else {
+    panGesture.reset([[UIPanGestureRecognizer alloc]
+        initWithTarget:self
+                action:@selector(panGesture:)]);
+  }
   [panGesture setMaximumNumberOfTouches:1];
   [panGesture setDelegate:self];
   [[self scrollView] addGestureRecognizer:panGesture];
   self.panGestureRecognizer = panGesture.get();
 }
 
 - (id<OverscrollActionsScrollView>)scrollView {
   if (_scrollview) {
     return static_cast<id<OverscrollActionsScrollView>>(_scrollview.get());
   } else {
@@ skipping 311 matching lines @@
       overscrollActionsController:self
                  didTriggerAction:self.overscrollActionView.selectedAction];
 }
 
 - (void)overscrollActionsView:(OverscrollActionsView*)view
       selectedActionDidChange:(OverscrollAction)newAction {
   TriggerHapticFeedbackForSelectionChange();
 }
 
 @end