[Workaround] Notify Overscroll Actions that a gesture ended.

[Workaround] Notify Overscroll Actions that a gesture ended.

The OverscrollActionController adds a UIPanGestureRecognizer.
When text is selected and SelectionSpeak is enabled, the
UIPanGestureRecognizer's end state is not always communicated to the
OverscrollActionController.

This CL calls the OverscrollActionController whenever the
UIPanGestureRecognizer is reset.

TEST=Enable SelectionSpeak. Visit a page. Select text. In a single gesture, scroll a
little bit up and down. Once you lift your finger from the screen, the browser
should not be frozen, i.e. you should be able to scroll the page.
BUG=699655

[jif, 2017-04-05 12:48:25]

Description was changed from

==========
Force notification that a gesture ended.

BUG=None.
==========

to

==========
[Workaround] Notify Overscroll Actions that a gesture ended.

The OverscrollActionController adds a UIPanGestureRecognizer.
When text is selected and SelectionSpeak is enabled, the
UIPanGestureRecognizer's
end state is not always communicated to the OverscrollActionController.

This CL calls the OverscrollActionController whenever the UIPanGestureRecognizer
is reset.

TEST=Enable SelectionSpeak. Visit a page. Select text. In a single gesture,
scroll a little bit up and down. Once you lift your finger from the screen, the
browser should not be frozen, i.e. you should be able to scroll the page.
BUG=699655
==========

[jif, 2017-04-05 12:48:25]

jif@chromium.org changed reviewers:
+ justincohen@chromium.org

[jif, 2017-04-05 12:49:22]

Description was changed from

==========
[Workaround] Notify Overscroll Actions that a gesture ended.

The OverscrollActionController adds a UIPanGestureRecognizer.
When text is selected and SelectionSpeak is enabled, the
UIPanGestureRecognizer's
end state is not always communicated to the OverscrollActionController.

This CL calls the OverscrollActionController whenever the UIPanGestureRecognizer
is reset.

TEST=Enable SelectionSpeak. Visit a page. Select text. In a single gesture,
scroll a little bit up and down. Once you lift your finger from the screen, the
browser should not be frozen, i.e. you should be able to scroll the page.
BUG=699655
==========

to

==========
[Workaround] Notify Overscroll Actions that a gesture ended.

The OverscrollActionController adds a UIPanGestureRecognizer.
When text is selected and SelectionSpeak is enabled, the
UIPanGestureRecognizer's end state is not always communicated to the
OverscrollActionController.

This CL calls the OverscrollActionController whenever the
UIPanGestureRecognizer is reset.

TEST=Enable SelectionSpeak. Visit a page. Select text. In a single gesture,
scroll a
little bit up and down. Once you lift your finger from the screen, the browser
should not be frozen, i.e. you should be able to scroll the page.
BUG=699655
==========

[jif, 2017-04-05 12:50:43]

ptal

[justincohen, 2017-04-05 14:22:08]

LGTM with questions.

https://codereview.chromium.org/2787723003/diff/40001/ios/chrome/browser/ui/o...
File ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
(right):

https://codereview.chromium.org/2787723003/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm:582:
if (UIAccessibilityIsSpeakSelectionEnabled()) {
Does -setup only get called once per process start?  Do we care if someone
enables speak selection after the app start?  Even if the answer is, I like that
this fix minimizes it's impact only to speak selection enabled...

https://codereview.chromium.org/2787723003/diff/40001/ios/chrome/browser/ui/o...
File
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm
(right):

https://codereview.chromium.org/2787723003/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm:8:
#include "base/mac/scoped_nsobject.h"
sort?

https://codereview.chromium.org/2787723003/diff/40001/ios/chrome/browser/ui/o...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_gesture_recognizer.mm:32:
- (void)removeTarget:(id)target action:(SEL)action {
This is all voodoo to me.  Why is this necessary? E.g. why is
overscroll_actions_controller::teardown::self.panGestureRecognizer = nil; not
enough?